Page MenuHomeFreeBSD
Differential D45181

LinuxKPI: add kvmemdup()
ClosedPublic
Actions

Authored by bz on May 13 2024, 5:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 10:19 PM
Unknown Object (File)
Thu, Mar 20, 9:53 AM
Unknown Object (File)
Sat, Mar 15, 4:05 AM
Unknown Object (File)
Mon, Mar 10, 2:22 AM
Unknown Object (File)
Feb 12 2025, 12:50 AM
Unknown Object (File)
Feb 7 2025, 3:10 AM
Unknown Object (File)
Feb 7 2025, 2:40 AM
Unknown Object (File)
Feb 2 2025, 6:25 PM
View All 58 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG395833f4ea8f: LinuxKPI: add kvmemdup()
rGa87e584f6c9d: LinuxKPI: add kvmemdup()
rG8e4b8e9d807a: LinuxKPI: add kvmemdup()
Summary

Add kvmemdup() as a variant of kmemdup().
This is used by an updated wireless driver.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57707
Build 54595: arc lint + arc unit

Event Timeline

bz created this revision.May 13 2024, 5:44 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptMay 13 2024, 5:44 PM
bz requested review of this revision.May 13 2024, 5:44 PM
Harbormaster completed remote builds in B57688: Diff 138487.May 13 2024, 5:44 PM
emaste accepted this revision.May 14 2024, 1:03 AM

Do we have our approach documented somewhere? This looks acceptable given that we already #define kvfree(arg) kfree(arg) but it would be good to have that mentioned somewhere.

This revision is now accepted and ready to land.May 14 2024, 1:03 AM
bz added a comment.May 14 2024, 9:43 PM
In D45181#1030842, @emaste wrote:

Do we have our approach documented somewhere? This looks acceptable given that we already #define kvfree(arg) kfree(arg) but it would be good to have that mentioned somewhere.

Other than the way we both looked probably not. kvfree() pre-dated me by a few years and given it is in slab.h I am not sure if there is a single place to document this well.

In theory I should probablu duplicate kmemdup and use kvmalloc() so in case someone ever decided to re-define kvmalloc/kvfree we wouldn't notice?

bz updated this revision to Diff 138556.May 14 2024, 11:01 PM

Duplicate the implmentation and add a comment for kvmalloc/kvfree in slab.h

I'll update the proposed commit message locally.

This revision now requires review to proceed.May 14 2024, 11:01 PM
Harbormaster completed remote builds in B57707: Diff 138556.May 14 2024, 11:01 PM
emaste accepted this revision.May 14 2024, 11:25 PM

In theory I should probablu duplicate kmemdup and use kvmalloc() so in case someone ever decided to re-define kvmalloc/kvfree we wouldn't notice?

Yeah that's better I think; I was thinking that a comment about us not having a distinction would be sufficient but this is future-proof against someone separating kmalloc from kvmalloc in the future.

This revision is now accepted and ready to land.May 14 2024, 11:25 PM
Closed by commit rG8e4b8e9d807a: LinuxKPI: add kvmemdup() (authored by bz). · Explain WhyMay 21 2024, 10:15 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG8e4b8e9d807a: LinuxKPI: add kvmemdup().
bz added a commit: rGa87e584f6c9d: LinuxKPI: add kvmemdup().Jun 12 2024, 4:42 PM
bz added a commit: rG395833f4ea8f: LinuxKPI: add kvmemdup().Jun 12 2024, 7:17 PM
emaste mentioned this in D45616: LinuxKPI: Add kvrealloc to linux/slab.h.Jun 17 2024, 1:05 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
12 lines

Diff 138556

View Options

sys/compat/linuxkpi/common/include/linux/string.h

Show All 12 Lines
SYSCTL_ADD_INT(ctx, children, OID_AUTO, SYSCTL_ADD_INT(ctx, children, OID_AUTO,
"watchdog_resets", "watchdog_resets",
CTLFLAG_RD, &sc->watchdog_resets, CTLFLAG_RD, &sc->watchdog_resets,
0, "Number of times NIC was reset"); 0, "Number of times NIC was reset");
/* performance related tunables */ /* performance related tunables */
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"intr_coal_delay", "intr_coal_delay", CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RW, sc, sc, 0, mxge_change_intr_coal, "I",
0, mxge_change_intr_coal, "interrupt coalescing delay in usecs");
gallatinUnsubmitted
Not Done
Inline Actions

Nothing in mxge needs giant

gallatin: Nothing in mxge needs giant
"I", "interrupt coalescing delay in usecs");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"throttle", "throttle", CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, sc, 0,
CTLTYPE_INT|CTLFLAG_RW, sc, mxge_change_throttle, "I", "transmit throttling");
0, mxge_change_throttle,
"I", "transmit throttling");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"flow_control_enabled", "flow_control_enabled",
CTLTYPE_INT|CTLFLAG_RW, sc, CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, sc, 0,
0, mxge_change_flow_control, mxge_change_flow_control, "I",
"I", "interrupt coalescing delay in usecs"); "interrupt coalescing delay in usecs");
SYSCTL_ADD_INT(ctx, children, OID_AUTO, SYSCTL_ADD_INT(ctx, children, OID_AUTO,
"deassert_wait", "deassert_wait",
CTLFLAG_RW, &mxge_deassert_wait, CTLFLAG_RW, &mxge_deassert_wait,
0, "Wait for IRQ line to go low in ihandler"); 0, "Wait for IRQ line to go low in ihandler");
/* stats block from firmware is in network byte order. /* stats block from firmware is in network byte order.
Need to swap it */ Need to swap it */
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"link_up", "link_up", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->link_up, &fw->link_up, 0, mxge_handle_be32, "I", "link up");
0, mxge_handle_be32,
"I", "link up");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"rdma_tags_available", "rdma_tags_available", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->rdma_tags_available, &fw->rdma_tags_available, 0, mxge_handle_be32, "I",
0, mxge_handle_be32, "rdma_tags_available");
"I", "rdma_tags_available");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_bad_crc32", "dropped_bad_crc32", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_bad_crc32, 0, mxge_handle_be32, "I",
&fw->dropped_bad_crc32, "dropped_bad_crc32");
0, mxge_handle_be32,
"I", "dropped_bad_crc32");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_bad_phy", "dropped_bad_phy", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_bad_phy, 0, mxge_handle_be32, "I", "dropped_bad_phy");
&fw->dropped_bad_phy,
0, mxge_handle_be32,
"I", "dropped_bad_phy");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_link_error_or_filtered", "dropped_link_error_or_filtered",
CTLTYPE_INT|CTLFLAG_RD, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
&fw->dropped_link_error_or_filtered, &fw->dropped_link_error_or_filtered, 0, mxge_handle_be32, "I",
0, mxge_handle_be32, "dropped_link_error_or_filtered");
"I", "dropped_link_error_or_filtered");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_link_overflow", "dropped_link_overflow",
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_link_overflow, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
0, mxge_handle_be32, &fw->dropped_link_overflow, 0, mxge_handle_be32, "I",
"I", "dropped_link_overflow"); "dropped_link_overflow");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_multicast_filtered", "dropped_multicast_filtered",
CTLTYPE_INT|CTLFLAG_RD, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
&fw->dropped_multicast_filtered, &fw->dropped_multicast_filtered, 0, mxge_handle_be32, "I",
0, mxge_handle_be32, "dropped_multicast_filtered");
"I", "dropped_multicast_filtered");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_no_big_buffer", "dropped_no_big_buffer",
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_no_big_buffer, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
0, mxge_handle_be32, &fw->dropped_no_big_buffer, 0, mxge_handle_be32, "I",
"I", "dropped_no_big_buffer"); "dropped_no_big_buffer");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_no_small_buffer", "dropped_no_small_buffer",
CTLTYPE_INT|CTLFLAG_RD, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
&fw->dropped_no_small_buffer, &fw->dropped_no_small_buffer, 0, mxge_handle_be32, "I",
0, mxge_handle_be32, "dropped_no_small_buffer");
"I", "dropped_no_small_buffer");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_overrun", "dropped_overrun",
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_overrun, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
0, mxge_handle_be32, &fw->dropped_overrun, 0, mxge_handle_be32, "I",
"I", "dropped_overrun"); "dropped_overrun");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_pause", "dropped_pause", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_pause, 0, mxge_handle_be32, "I", "dropped_pause");
&fw->dropped_pause,
0, mxge_handle_be32,
"I", "dropped_pause");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_runt", "dropped_runt", CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_runt, &fw->dropped_runt, 0, mxge_handle_be32, "I", "dropped_runt");
0, mxge_handle_be32,
"I", "dropped_runt");
SYSCTL_ADD_PROC(ctx, children, OID_AUTO, SYSCTL_ADD_PROC(ctx, children, OID_AUTO,
"dropped_unicast_filtered", "dropped_unicast_filtered",
CTLTYPE_INT|CTLFLAG_RD, &fw->dropped_unicast_filtered, CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT,
0, mxge_handle_be32, &fw->dropped_unicast_filtered, 0, mxge_handle_be32, "I",
"I", "dropped_unicast_filtered"); "dropped_unicast_filtered");
/* verbose printing? */ /* verbose printing? */
SYSCTL_ADD_INT(ctx, children, OID_AUTO, SYSCTL_ADD_INT(ctx, children, OID_AUTO,
"verbose", "verbose",
CTLFLAG_RW, &mxge_verbose, CTLFLAG_RW, &mxge_verbose,
0, "verbose printing"); 0, "verbose printing");
/* add counters exported for debugging from all slices */ /* add counters exported for debugging from all slices */
sysctl_ctx_init(&sc->slice_sysctl_ctx); sysctl_ctx_init(&sc->slice_sysctl_ctx);
sc->slice_sysctl_tree = sc->slice_sysctl_tree =
SYSCTL_ADD_NODE(&sc->slice_sysctl_ctx, children, OID_AUTO, SYSCTL_ADD_NODE(&sc->slice_sysctl_ctx, children, OID_AUTO,
"slice", CTLFLAG_RD, 0, ""); "slice", CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "");
for (slice = 0; slice < sc->num_slices; slice++) { for (slice = 0; slice < sc->num_slices; slice++) {
ss = &sc->ss[slice]; ss = &sc->ss[slice];
sysctl_ctx_init(&ss->sysctl_ctx); sysctl_ctx_init(&ss->sysctl_ctx);
ctx = &ss->sysctl_ctx; ctx = &ss->sysctl_ctx;
children = SYSCTL_CHILDREN(sc->slice_sysctl_tree); children = SYSCTL_CHILDREN(sc->slice_sysctl_tree);
sprintf(slice_num, "%d", slice); sprintf(slice_num, "%d", slice);
ss->sysctl_tree = ss->sysctl_tree =
SYSCTL_ADD_NODE(ctx, children, OID_AUTO, slice_num, SYSCTL_ADD_NODE(ctx, children, OID_AUTO, slice_num,
CTLFLAG_RD, 0, ""); CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "");
children = SYSCTL_CHILDREN(ss->sysctl_tree); children = SYSCTL_CHILDREN(ss->sysctl_tree);
SYSCTL_ADD_INT(ctx, children, OID_AUTO, SYSCTL_ADD_INT(ctx, children, OID_AUTO,
"rx_small_cnt", "rx_small_cnt",
CTLFLAG_RD, &ss->rx_small.cnt, CTLFLAG_RD, &ss->rx_small.cnt,
0, "rx_small_cnt"); 0, "rx_small_cnt");
SYSCTL_ADD_INT(ctx, children, OID_AUTO, SYSCTL_ADD_INT(ctx, children, OID_AUTO,
"rx_big_cnt", "rx_big_cnt",
CTLFLAG_RD, &ss->rx_big.cnt, CTLFLAG_RD, &ss->rx_big.cnt,
Show All 12 Lines