Page MenuHomeFreeBSD
Differential D45134

Allow -DNO_STRICT_ERE to restore historic regex behavior
ClosedPublic
Actions

Authored by sjg on May 8 2024, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 28, 11:22 AM
Unknown Object (File)
Thu, May 28, 4:53 AM
Unknown Object (File)
Thu, May 28, 2:14 AM
Unknown Object (File)
Thu, May 28, 12:43 AM
Unknown Object (File)
Mon, May 25, 9:38 AM
Unknown Object (File)
Wed, May 13, 5:33 AM
Unknown Object (File)
Wed, May 13, 5:33 AM
Unknown Object (File)
Wed, May 13, 5:31 AM
View All 95 Files
Subscribers
imp

Details

Reviewers
kevans
Commits
rGf77b5b295da3: Allow -DNO_STRICT_REGEX to restore historic regex behavior
Summary

Allow restoring the behavior of '{' as described in regex(3).
Ie. only treat it as start of bounds if followed by a digit.

If NO_STRICT_ERE is not defined, the behavior introduced by
commit a4a801688c909ef39cbcbc3488bc4fdbabd69d66 is retained,
otherwise the previous behavior is restored.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57626
Build 54514: arc lint + arc unit

Event Timeline

sjg created this revision.May 8 2024, 10:15 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 8 2024, 10:15 PM
sjg requested review of this revision.May 8 2024, 10:15 PM
Harbormaster completed remote builds in B57626: Diff 138271.May 8 2024, 10:15 PM
kevans added inline comments.May 8 2024, 10:30 PM
lib/libc/regex/regcomp.c
910

It occurs to me that this is the BRE path, but it'd be good for the knob to be consistent across BREs and EREs- maybe just rename the knob to NO_STRICT_REGEX? I don't think I have any complaints otherwise.

sjg updated this revision to Diff 138275.May 8 2024, 11:13 PM

Rename knob to NO_STRICT_REGEX

Harbormaster completed remote builds in B57630: Diff 138275.May 8 2024, 11:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 10 2024, 1:31 AM
Closed by commit rGf77b5b295da3: Allow -DNO_STRICT_REGEX to restore historic regex behavior (authored by sjg). · Explain Why
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rGf77b5b295da3: Allow -DNO_STRICT_REGEX to restore historic regex behavior.

Revision Contents
Changeset List

PathSize
lib/
libc/
regex/
20 lines

Diff 138271

View Options

lib/libc/regex/regcomp.c

Loading...