Page MenuHomeFreeBSD
Differential D44908

geli.8: add some notes regarding performance tuning
ClosedPublic
Actions

Authored by asomers on Apr 22 2024, 10:33 PM.
Tags
None
Referenced Files
F175130025: D44908.diff
Thu, Oct 8, 12:20 PM
Unknown Object (File)
Mon, Oct 5, 12:57 AM
Unknown Object (File)
Sun, Oct 4, 8:52 PM
Unknown Object (File)
Tue, Sep 29, 6:45 PM
Unknown Object (File)
Tue, Sep 29, 6:44 PM
Unknown Object (File)
Wed, Sep 9, 9:40 PM
Unknown Object (File)
Sep 6 2026, 12:53 AM
Unknown Object (File)
Sep 5 2026, 7:32 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
Commits
rG4b7949144cfb: geli.8: add some notes regarding performance tuning
Summary

MFC after: 1 weel
Sponsored by: Axcient

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 57284
Build 54172: arc lint + arc unit

Event Timeline

asomers created this revision.Apr 22 2024, 10:33 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 22 2024, 10:33 PM
asomers requested review of this revision.Apr 22 2024, 10:33 PM
Harbormaster completed remote builds in B57284: Diff 137529.Apr 22 2024, 10:33 PM
markj added inline comments.Apr 23 2024, 4:00 PM
lib/geom/eli/geli.8
859
861
909

Maybe also note that this variable needs to be set before the volume is attached. It's confusing that the default value is 0 when that really means it's equal to NCPU.

916

or combine with the previous sentence.

asomers marked 3 inline comments as done.Apr 23 2024, 5:26 PM
asomers added inline comments.
lib/geom/eli/geli.8
909

Ok. I added that note to the previous section.

asomers updated this revision to Diff 137567.Apr 23 2024, 5:27 PM
  • Respond to markj's feedback.
Harbormaster completed remote builds in B57305: Diff 137567.Apr 23 2024, 5:27 PM
markj accepted this revision.Apr 24 2024, 12:38 PM

Seems ok, thank you. I included a couple of suggestions.

lib/geom/eli/geli.8
856
919
This revision is now accepted and ready to land.Apr 24 2024, 12:38 PM
Closed by commit rG4b7949144cfb: geli.8: add some notes regarding performance tuning (authored by asomers). · Explain WhyApr 24 2024, 1:54 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG4b7949144cfb: geli.8: add some notes regarding performance tuning.
asomers mentioned this in rG1c5b58a71718: geli.8: minor proofreading.May 9 2024, 8:25 PM

Revision Contents
Changeset List

PathSize
lib/
geom/
eli/
35 lines

Diff 137529

View Options

lib/geom/eli/geli.8

Loading...