mfc-candidates: move pretty printing into lua
ClosedPublic
Actions

Authored by emaste on Apr 18 2024, 1:40 PM.

Details

Reviewers

imp
kevans

Commits

rG311f95ce3d41: mfc-candidates: move pretty printing into lua
rG793745fad866: mfc-candidates: move pretty printing into lua

Summary

d51c59002367 moved the MFC hash matching logic into a lua utility
script but left the output formatting in the shell script. Simplify this
slightly by just printing the formatted output from lua.

Eventually I'd like to just remove mfc-candidates.sh and have everything in lua, but haven't had a chance to spend time on it. This is a tiny step on that path with that in mind.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Apr 18 2024, 1:40 PM

emaste created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2024, 2:12 PM

Closed by commit rG793745fad866: mfc-candidates: move pretty printing into lua (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG793745fad866: mfc-candidates: move pretty printing into lua.

imp added inline comments.Apr 21 2024, 2:54 PM

tools/tools/git/candidatematch.lua
68	That reminds me... it would be nice if we had an option to just print the hashes in the proper order... And it might also not be a bad idea to come up with lua "bindings" for git in the fullness of time.