Page MenuHomeFreeBSD
Differential D5369

net80211: hide subtype mask & shift in function call
ClosedPublic
Actions

Authored by avos on Feb 20 2016, 8:51 PM.
Tags
None
Referenced Files
F93784990: D5369.diff
Thu, Sep 12, 1:10 PM
Unknown Object (File)
Mon, Sep 9, 3:31 AM
Unknown Object (File)
Mon, Sep 9, 3:22 AM
Unknown Object (File)
Mon, Sep 9, 2:38 AM
Unknown Object (File)
Sun, Sep 8, 9:19 AM
Unknown Object (File)
Sun, Sep 8, 9:19 AM
Unknown Object (File)
Sun, Sep 8, 9:19 AM
Unknown Object (File)
Sun, Sep 8, 9:19 AM
View All 86 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS298376: net80211: hide subtype mask & shift in function call.
Summary

Hide subtype mask/shift (which is used for index calculation in ieee80211_mgt_subtype_name[] array) in function call.

Test Plan

Tested with RTL8188CUS, STA mode.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 13554.Feb 20 2016, 8:51 PM
avos retitled this revision from to net80211: hide subtype shift in function call.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2016, 8:51 PM
adrian accepted this revision.Feb 24 2016, 6:24 AM
adrian edited edge metadata.

let's make the two subtype functions also do the mask, and reduce code duplication there. Then yeah, commit away!

sys/net80211/ieee80211_input.c
929–930

may as well have the function also do the mask, right?

This revision is now accepted and ready to land.Feb 24 2016, 6:24 AM
avos updated this revision to Diff 13695.Feb 24 2016, 10:02 PM
avos retitled this revision from net80211: hide subtype shift in function call to net80211: hide subtype mask & shift in function call.
avos updated this object.
avos edited edge metadata.

Mask subtype before shifting.

This revision now requires review to proceed.Feb 24 2016, 10:02 PM
avos marked an inline comment as done.Feb 24 2016, 10:02 PM
adrian accepted this revision.Feb 24 2016, 10:26 PM
adrian edited edge metadata.

yay!

This revision is now accepted and ready to land.Feb 24 2016, 10:26 PM
Closed by commit rS298376: net80211: hide subtype mask & shift in function call. (authored by avos). · Explain WhyApr 20 2016, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13695

View Options

sys/net80211/ieee80211_adhoc.c

Loading...
View Options

sys/net80211/ieee80211_hostap.c

Loading...
View Options

sys/net80211/ieee80211_input.h

Loading...
View Options

sys/net80211/ieee80211_input.c

Loading...
View Options

sys/net80211/ieee80211_mesh.c

Loading...
View Options

sys/net80211/ieee80211_output.c

Loading...
View Options

sys/net80211/ieee80211_proto.h

Loading...
View Options

sys/net80211/ieee80211_proto.c

Loading...
View Options

sys/net80211/ieee80211_scan.c

Loading...
View Options

sys/net80211/ieee80211_sta.c

Loading...
View Options

sys/net80211/ieee80211_tdma.c

Loading...
View Options

sys/net80211/ieee80211_wds.c

Loading...