ln: Improve link(1) variant of ln(1).
ClosedPublic
Actions

Authored by des on Apr 4 2024, 1:34 PM.

Details

Reviewers

Group Reviewers

Klara
tests

Commits

rGdc0087a3aa78: ln: Improve link(1) variant of ln(1).
rGe9ab8b45822f: ln: Improve link(1) variant of ln(1).
rGbee7cf9e97f6: ln: Improve link(1) variant of ln(1).

Summary

Give link(1) its own usage message.
Use getprogname(3) instead of rolling our own.
Verify that the target file does not already exist.
Add tests specific to link(1).

MFC after: 3 days
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56912
Build 53800: arc lint + arc unit

Event Timeline

des created this revision.Apr 4 2024, 1:34 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 4 2024, 1:34 PM

des requested review of this revision.Apr 4 2024, 1:34 PM

Harbormaster completed remote builds in B56912: Diff 136531.Apr 4 2024, 1:34 PM

des added a reviewer: tests.Apr 4 2024, 1:35 PM

don't get fooled by symlinks

Harbormaster completed remote builds in B56913: Diff 136534.Apr 4 2024, 1:55 PM

allanjude accepted this revision as: allanjude.Apr 4 2024, 2:08 PM

This revision is now accepted and ready to land.Apr 4 2024, 2:08 PM

Closed by commit rGbee7cf9e97f6: ln: Improve link(1) variant of ln(1). (authored by des). · Explain WhyApr 4 2024, 2:15 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGbee7cf9e97f6: ln: Improve link(1) variant of ln(1)..

des added a commit: rGe9ab8b45822f: ln: Improve link(1) variant of ln(1)..Apr 8 2024, 10:11 AM

des added a commit: rGdc0087a3aa78: ln: Improve link(1) variant of ln(1)..

Revision Contents
Changeset List

Path

Size

bin/

ln/

ln.c

32 lines

tests/

ln_test.sh

59 lines

Diff 136531

View Options

bin/ln/ln.c