Page MenuHomeFreeBSD
Differential D44591

LinuxKPI: napi_schedule() requires return value
ClosedPublic
Actions

Authored by bz on Apr 2 2024, 10:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 16, 2:15 AM
Unknown Object (File)
Thu, Dec 11, 2:43 PM
Unknown Object (File)
Thu, Dec 4, 11:30 PM
Unknown Object (File)
Sat, Nov 29, 12:13 AM
Unknown Object (File)
Wed, Nov 26, 9:02 PM
Unknown Object (File)
Wed, Nov 26, 2:49 AM
Unknown Object (File)
Sat, Nov 22, 3:15 PM
Unknown Object (File)
Wed, Nov 19, 5:59 PM
View All 96 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG4d9e8a65d031: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled()
rG25e0847ef7d2: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled()
rG21761f2ede4e: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled()
Summary

napi_schedule() now requires a return value in iwlwifi; unclear if it
always did but was never needed. Add the bool to test based on the
napi_schedule_prep() result.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56882
Build 53770: arc lint + arc unit

Event Timeline

bz created this revision.Apr 2 2024, 10:07 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptApr 2 2024, 10:07 AM
bz requested review of this revision.Apr 2 2024, 10:07 AM
Harbormaster completed remote builds in B56869: Diff 136433.Apr 2 2024, 10:07 AM
emaste accepted this revision.Apr 2 2024, 12:20 PM
This revision is now accepted and ready to land.Apr 2 2024, 12:20 PM
bz updated this revision to Diff 136457.Apr 2 2024, 11:59 PM

Update with some more

This revision now requires review to proceed.Apr 2 2024, 11:59 PM
Harbormaster completed remote builds in B56882: Diff 136457.Apr 2 2024, 11:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 15 2024, 4:21 PM
Closed by commit rG21761f2ede4e: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled() (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG21761f2ede4e: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled().
bz added a commit: rG25e0847ef7d2: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled().Apr 22 2024, 7:44 PM
bz added a commit: rG4d9e8a65d031: LinuxKPI: napi_schedule() requires return value, implement napi_is_scheduled().Jun 12 2024, 7:17 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
9 lines
src/
8 lines

Diff 136457

View Options

sys/compat/linuxkpi/common/include/linux/netdevice.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_netdev.c

Loading...