touch: Allow setting the timestamp to -1.
ClosedPublic
Actions

Authored by des on Mar 26 2024, 3:37 AM.

Details

Reviewers

Commits

rGae2888dd0e25: touch: Allow setting the timestamp to -1.
rGfc7287456321: touch: Allow setting the timestamp to -1.
rGaa69e0f21263: touch: Allow setting the timestamp to -1.

Summary

Note that VFS internally interprets a timestamp of -1 as “do not set”,
so this has no effect, but at least touch won't incorrectly reject the
given date / time (1969-12-31 23:59:59 UTC) as invalid.

While here, fix some style issues.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56780
Build 53668: arc lint + arc unit

Event Timeline

des created this revision.Mar 26 2024, 3:37 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 26 2024, 3:37 AM

des requested review of this revision.Mar 26 2024, 3:37 AM

Harbormaster completed remote builds in B56780: Diff 136211.Mar 26 2024, 3:37 AM

des added a child revision: D44505: touch: Add unit tests..Mar 26 2024, 11:30 AM

reviewed-by: allanjude

This revision is now accepted and ready to land.Mar 26 2024, 3:26 PM

Closed by commit rGaa69e0f21263: touch: Allow setting the timestamp to -1. (authored by des). · Explain WhyMar 27 2024, 11:28 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGaa69e0f21263: touch: Allow setting the timestamp to -1..

des added a commit: rGfc7287456321: touch: Allow setting the timestamp to -1..Apr 4 2024, 11:40 AM

des added a commit: rGae2888dd0e25: touch: Allow setting the timestamp to -1..

Revision Contents
Changeset List

Path

Size

usr.bin/

touch/

touch.c

21 lines

Diff 136211

View Options

touch: Allow setting the timestamp to -1.ClosedPublicActions