Page MenuHomeFreeBSD
Differential D43171

net/samba416: Patch for abnormal abort on 14.0 i386
ClosedPublic
Actions

Authored by jrm on Dec 24 2023, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 9, 6:23 PM
Unknown Object (File)
Thu, May 9, 6:23 PM
Unknown Object (File)
Thu, May 9, 2:27 PM
Unknown Object (File)
Thu, May 9, 2:27 PM
Unknown Object (File)
Thu, May 9, 3:59 AM
Unknown Object (File)
Thu, May 9, 3:49 AM
Unknown Object (File)
Fri, Apr 26, 2:45 AM
Unknown Object (File)
Wed, Apr 24, 3:41 AM
View All 28 Files
Subscribers
martin_lispworks.com

Details

Reviewers
timur
Commits
R11:3fb51f85c5f3: net/samba416: Patch to prevent abnormal smbd abort
Summary

PR: 275597

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 55325
Build 52214: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Dec 24 2023, 3:10 PM
jrm created this revision.
Harbormaster completed remote builds in B55099: Diff 131795.Dec 24 2023, 3:10 PM
jrm updated this revision to Diff 131796.Dec 24 2023, 4:42 PM

Add missing path when adding to EXTRA_PATCHES

Harbormaster completed remote builds in B55100: Diff 131796.Dec 24 2023, 4:42 PM
martin_lispworks.com added a subscriber: martin_lispworks.com.Jan 9 2024, 1:57 PM

This bug affects all platforms, not just i386. I think it is actually a bug in Samba.

As noted later in PR: 275597, the problem is that result+sizeof(struct dirent) might be in unmapped memory. It seems that readdir() only guarantees that memory up to result+result->d_reclen is readable.

jrm updated this revision to Diff 132497.Jan 9 2024, 2:49 PM

Apply patch to all platforms

Harbormaster completed remote builds in B55325: Diff 132497.Jan 9 2024, 2:49 PM
jrm updated this revision to Diff 132554.Jan 10 2024, 6:06 PM

memcpy() d_reclen bytes rather than setting each field

Harbormaster completed remote builds in B55353: Diff 132554.Jan 10 2024, 6:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2024, 4:24 AM
Closed by commit R11:3fb51f85c5f3: net/samba416: Patch to prevent abnormal smbd abort (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:3fb51f85c5f3: net/samba416: Patch to prevent abnormal smbd abort.

Revision Contents
Changeset List

PathSize
net/
samba416/
files/
20 lines

Diff 132497

View Options

net/samba416/files/patch-source3_modules_vfs__cap.c

Loading...