Page MenuHomeFreeBSD
Differential D5252

netfront: remove useless NULL check in netif_free
ClosedPublic
Actions

Authored by liuw_liuw.name on Feb 11 2016, 11:40 AM.
Tags
None
Referenced Files
F166605446: D5252.id13214.diff
Fri, Aug 14, 8:22 PM
Unknown Object (File)
Thu, Aug 13, 1:05 AM
Unknown Object (File)
Tue, Aug 11, 11:26 PM
Unknown Object (File)
Mon, Aug 10, 4:58 PM
Unknown Object (File)
Mon, Aug 10, 11:30 AM
Unknown Object (File)
Sun, Aug 9, 11:04 AM
Unknown Object (File)
Sun, Aug 9, 11:04 AM
Unknown Object (File)
Sat, Aug 8, 5:09 AM
View All 94 Files
Subscribers
imp

Details

Reviewers
royger
Commits
rS295513: xen-netfront: remove useless NULL check in netif_free
Summary

xn_ifp is allocated in create_netdev with if_alloc(IFT_ETHER).
According to the current arrangement it can't be NULL.

This is CID 1349805.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2461
Build 2478: arc lint + arc unit

Event Timeline

liuw_liuw.name updated this revision to Diff 13214.Feb 11 2016, 11:40 AM
liuw_liuw.name retitled this revision from to netfront: remove useless NULL check in netif_free.
liuw_liuw.name updated this object.
liuw_liuw.name edited the test plan for this revision. (Show Details)
liuw_liuw.name added a reviewer: royger.
Herald added a subscriber: imp. · View Herald TranscriptFeb 11 2016, 11:40 AM
royger accepted this revision.Feb 11 2016, 11:54 AM
royger edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2016, 11:54 AM
Closed by commit rS295513: xen-netfront: remove useless NULL check in netif_free (authored by royger). · Explain WhyFeb 11 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
xen/
netfront/
8 lines

Diff 13214

View Options

sys/dev/xen/netfront/netfront.c

Loading...