Page MenuHomeFreeBSD
Differential D42850

net/freeipa-client: Add new port
ClosedPublic
Actions

Authored by kiwi on Nov 30 2023, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 5:13 AM
Unknown Object (File)
Thu, Jan 30, 4:37 AM
Unknown Object (File)
Thu, Jan 30, 4:37 AM
Unknown Object (File)
Dec 10 2024, 11:16 AM
Unknown Object (File)
Nov 24 2024, 11:28 PM
Unknown Object (File)
Nov 23 2024, 4:36 PM
Unknown Object (File)
Nov 19 2024, 4:06 PM
Unknown Object (File)
Nov 11 2024, 12:52 PM
View All Files
Subscribers
diizzy

Details

Reviewers
0mp
Commits
R11:d6f2f39fa8b9: net/freeipa-client: Add new port

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54962
Build 51851: arc lint + arc unit

Event Timeline

kiwi requested review of this revision.Nov 30 2023, 2:44 PM
kiwi created this revision.
Harbormaster completed remote builds in B54708: Diff 130850.Nov 30 2023, 2:44 PM
0mp added a reviewer: 0mp.Nov 30 2023, 2:59 PM
diizzy added a subscriber: diizzy.Dec 1 2023, 4:59 PM

I also think Python bytecode files needs to go.

net/freeipa-client/Makefile
13

LICENSE_FILE
https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license

32

CONFIGURE_ARGS=

34

Unnecessary, https://cgit.freebsd.org/ports/tree/Mk/bsd.port.mk#n755

40

Probably a better solution, https://cgit.freebsd.org/ports/tree/net-mgmt/netdata/Makefile#n32

kiwi added inline comments.Dec 11 2023, 9:36 AM
net/freeipa-client/Makefile
34

Thanks !

40

Many thanks about this better solution.

kiwi updated this revision to Diff 131250.Dec 11 2023, 2:39 PM

Fix Makefile LICENSE_FILE, CONFIGURE_ARGS, and some unnecessary things. Remove also duplicated patch files that should not be here

Harbormaster completed remote builds in B54890: Diff 131250.Dec 11 2023, 2:39 PM
kiwi marked 4 inline comments as done.Dec 11 2023, 2:40 PM
kiwi updated this revision to Diff 131467.Dec 15 2023, 8:16 AM

This port doesn't build on 12.4 poudriere, so mark it as BROKEN.
On 13.2 and 14.0 it is building without any pain, didn't tryed on 15.0
indeed.

Harbormaster completed remote builds in B54960: Diff 131467.Dec 15 2023, 8:16 AM
0mp accepted this revision.Dec 15 2023, 12:33 PM

Thanks, I'll commit it shortly.

This revision is now accepted and ready to land.Dec 15 2023, 12:33 PM
kiwi updated this revision to Diff 131471.Dec 15 2023, 2:30 PM

Configuration file should be in sample

This revision now requires review to proceed.Dec 15 2023, 2:30 PM
Harbormaster completed remote builds in B54962: Diff 131471.Dec 15 2023, 2:30 PM
kiwi updated this revision to Diff 131472.Dec 15 2023, 2:41 PM

Typo on the filename

Harbormaster completed remote builds in B54963: Diff 131472.Dec 15 2023, 2:41 PM
diizzy added a comment.Dec 15 2023, 4:20 PM

Might also want to look at this ENV https://docs.python.org/3/using/cmdline.html#envvar-PYTHONDONTWRITEBYTECODE

kiwi updated this revision to Diff 131602.Dec 20 2023, 8:17 AM

Better suggested way to avoid python bycode files than using rm.

Harbormaster completed remote builds in B55041: Diff 131602.Dec 20 2023, 8:17 AM
0mp accepted this revision.Dec 22 2023, 12:08 PM
This revision is now accepted and ready to land.Dec 22 2023, 12:08 PM
Closed by commit R11:d6f2f39fa8b9: net/freeipa-client: Add new port (authored by kiwi, committed by 0mp). · Explain WhyDec 22 2023, 12:19 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: R11:d6f2f39fa8b9: net/freeipa-client: Add new port.

Revision Contents
Changeset List

Diff 131471

View Options

net/Makefile

Loading...
View Options

net/freeipa-client/Makefile

Loading...
View Options

net/freeipa-client/distinfo

Loading...
View Options

net/freeipa-client/files/patch-asn1_asn1c_INTEGER.c

Loading...
View Options

net/freeipa-client/files/patch-asn1_asn1c_Makefile.am

Loading...
View Options

net/freeipa-client/files/patch-asn1_asn1c_NativeEnumerated.c

Loading...
View Options

net/freeipa-client/files/patch-asn1_asn1c_der__encoder.c

Loading...
View Options

net/freeipa-client/files/patch-client_Makefile.am

Loading...
View Options

net/freeipa-client/files/patch-client_ipa-getkeytab.c

Loading...
View Options

net/freeipa-client/files/patch-configure.ac

Loading...
View Options

net/freeipa-client/files/patch-daemons_Makefile.am

Loading...
View Options

net/freeipa-client/files/patch-init_Makefile.am

Loading...
View Options

net/freeipa-client/files/patch-ipaplatform_freebsd_____init____.py

Loading...
View Options

net/freeipa-client/files/patch-ipaplatform_setup.py

Loading...
View Options

net/freeipa-client/files/patch-util_ipa__krb5.c

Loading...
View Options

net/freeipa-client/pkg-descr

Loading...
View Options

net/freeipa-client/pkg-plist

Loading...