Differential D43064

cp: Further simplify the core logic.
ClosedPublic
Actions

Authored by des on Dec 14 2023, 3:58 PM.

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rG38509270663f: cp: Further simplify the core logic.

Summary

If the destination file exists but we decide unlink it, set the dne
flag. This means we don't need to re-check the conditions that would
have caused us to delete the file when we later need to decide whether
to create or replace it.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54950
Build 51839: arc lint + arc unit

Event Timeline

des created this revision.Dec 14 2023, 3:58 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2023, 3:58 PM

des requested review of this revision.Dec 14 2023, 3:58 PM

Harbormaster completed remote builds in B54950: Diff 131440.Dec 14 2023, 3:58 PM

kevans accepted this revision.Dec 14 2023, 4:03 PM

This revision is now accepted and ready to land.Dec 14 2023, 4:03 PM

des retitled this revision from cp: Simplify core logic further. to cp: Further simplify the core logic..Dec 14 2023, 4:05 PM

Closed by commit rG38509270663f: cp: Further simplify the core logic. (authored by des). · Explain WhyDec 14 2023, 4:08 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG38509270663f: cp: Further simplify the core logic..

des mentioned this in rGd514cadacc50: cp: Add tests for hard link case..Jan 17 2024, 6:28 PM

des mentioned this in rG006017419bea: cp: Add tests for hard link case..

Revision Contents
Changeset List

Path

Size

bin/

cp/

utils.c

3 lines

Diff 131440

View Options

cp: Further simplify the core logic.ClosedPublicActions