Page MenuHomeFreeBSD
Differential D43052

cp: Add tests for hard link case.
ClosedPublic
Actions

Authored by des on Dec 13 2023, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 4:48 PM
Unknown Object (File)
Feb 3 2025, 10:52 AM
Unknown Object (File)
Jan 27 2025, 5:06 PM
Unknown Object (File)
Jan 27 2025, 4:36 PM
Unknown Object (File)
Jan 27 2025, 7:26 AM
Unknown Object (File)
Jan 24 2025, 5:51 PM
Unknown Object (File)
Jan 24 2025, 5:40 PM
Unknown Object (File)
Jan 23 2025, 6:31 PM
View All 64 Files
Subscribers
guest-patmaddox
imp

Details

Reviewers
kevans
Group Reviewers
Klara
tests
Commits
rG006017419bea: cp: Add tests for hard link case.
rGd514cadacc50: cp: Add tests for hard link case.
rG1fead66b6482: cp: Add tests for hard link case.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Dec 13 2023, 8:39 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 13 2023, 8:39 PM
des requested review of this revision.Dec 13 2023, 8:39 PM
Harbormaster completed remote builds in B54934: Diff 131391.Dec 13 2023, 8:39 PM
kevans accepted this revision as: Klara, kevans.Dec 13 2023, 8:47 PM
This revision is now accepted and ready to land.Dec 13 2023, 8:47 PM
des updated this revision to Diff 131392.Dec 13 2023, 8:48 PM

rm unused variables

This revision now requires review to proceed.Dec 13 2023, 8:48 PM
Harbormaster completed remote builds in B54935: Diff 131392.Dec 13 2023, 8:48 PM
des updated this revision to Diff 131393.Dec 13 2023, 8:51 PM

check that foo and bar are different

Harbormaster completed remote builds in B54936: Diff 131393.Dec 13 2023, 8:51 PM
des retitled this revision from cp: Add tests for -l option. to cp: Add tests for hard link case..Dec 13 2023, 8:58 PM
des updated this revision to Diff 131394.Dec 13 2023, 8:58 PM

sort test cases

Harbormaster completed remote builds in B54937: Diff 131394.Dec 13 2023, 8:58 PM
kevans accepted this revision as: Klara, kevans.Dec 13 2023, 9:00 PM
This revision is now accepted and ready to land.Dec 13 2023, 9:00 PM
Closed by commit rG1fead66b6482: cp: Add tests for hard link case. (authored by des). · Explain WhyDec 13 2023, 9:31 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG1fead66b6482: cp: Add tests for hard link case..
guest-patmaddox added a subscriber: guest-patmaddox.Dec 13 2023, 10:03 PM
des mentioned this in D43054: cp: Add tests for symbolic link case..Dec 13 2023, 11:07 PM
des added a commit: rGd514cadacc50: cp: Add tests for hard link case..Jan 17 2024, 6:28 PM
des added a commit: rG006017419bea: cp: Add tests for hard link case..

Revision Contents
Changeset List

PathSize
bin/
cp/
tests/
32 lines

Diff 131396

View Options

bin/cp/tests/cp_test.sh

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
static __inline uint64_t * \ static __inline uint64_t * \
name##_PCTRIE_PTR2VAL(struct type *ptr) \ name##_PCTRIE_PTR2VAL(struct type *ptr) \
{ \ { \
\ \
return &ptr->field; \ return &ptr->field; \
} \ } \
\ \
static __inline __unused int \ static __inline __unused int \
name##_PCTRIE_INSERT(struct pctrie *ptree, struct type *ptr) \ name##_PCTRIE_INSERT_BASE(struct pctrie *ptree, void *parentp, \
uint64_t *val, uint64_t *found, struct type **found_out) \
{ \ { \
struct pctrie_node *parent; \ struct pctrie_node *parent; \
void *parentp; \
uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \
\ \
parentp = pctrie_insert_lookup_strict(ptree, val); \ if (__predict_false(found != NULL)) { \
if (parentp == NULL) \ *found_out = name##_PCTRIE_VAL2PTR(found); \
return (0); \ return (EEXIST); \
} \
if (parentp != NULL) { \
parent = allocfn(ptree); \ parent = allocfn(ptree); \
if (__predict_false(parent == NULL)) \ if (__predict_false(parent == NULL)) { \
if (found_out != NULL) \
*found_out = NULL; \
return (ENOMEM); \ return (ENOMEM); \
} \
pctrie_insert_node(parentp, parent, val); \ pctrie_insert_node(parentp, parent, val); \
} \
return (0); \ return (0); \
} \ } \
\ \
static __inline __unused int \ static __inline __unused int \
name##_PCTRIE_INSERT(struct pctrie *ptree, struct type *ptr) \
{ \
void *parentp; \
uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \
\
parentp = pctrie_insert_lookup_strict(ptree, val); \
return (name##_PCTRIE_INSERT_BASE(ptree, parentp, val, \
NULL, NULL)); \
} \
\
static __inline __unused int \
name##_PCTRIE_FIND_OR_INSERT(struct pctrie *ptree, struct type *ptr, \ name##_PCTRIE_FIND_OR_INSERT(struct pctrie *ptree, struct type *ptr, \
struct type **found_out_opt) \ struct type **found_out_opt) \
{ \ { \
struct pctrie_node *parent; \
void *parentp; \ void *parentp; \
uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \ uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \
uint64_t *found; \ uint64_t *found; \
\ \
parentp = pctrie_insert_lookup(ptree, val, &found); \ parentp = pctrie_insert_lookup(ptree, val, &found); \
if (found != NULL) { \ return (name##_PCTRIE_INSERT_BASE(ptree, parentp, val, \
if (found_out_opt != NULL) \ found, found_out_opt)); \
*found_out_opt = name##_PCTRIE_VAL2PTR(found); \
return (EEXIST); \
} \ } \
if (parentp == NULL) \
return (0); \
parent = allocfn(ptree); \
if (__predict_false(parent == NULL)) \
return (ENOMEM); \
pctrie_insert_node(parentp, parent, val); \
return (0); \
} \
\ \
static __inline __unused int \ static __inline __unused int \
name##_PCTRIE_INSERT_LOOKUP_GE(struct pctrie *ptree, struct type *ptr, \ name##_PCTRIE_INSERT_LOOKUP_GE(struct pctrie *ptree, struct type *ptr, \
struct type **found_out) \ struct type **found_out) \
{ \ { \
struct pctrie_node *parent, *neighbor; \ struct pctrie_node *neighbor; \
void *parentp; \ void *parentp; \
uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \ uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \
uint64_t *found; \ uint64_t *found; \
int retval; \
\ \
parentp = pctrie_insert_lookup_gt(ptree, val, &found, \ parentp = pctrie_insert_lookup_gt(ptree, val, &found, \
&neighbor); \ &neighbor); \
if (__predict_false(found != NULL)) { \ retval = name##_PCTRIE_INSERT_BASE(ptree, parentp, val, \
*found_out = name##_PCTRIE_VAL2PTR(found); \ found, found_out); \
return (EEXIST); \ if (retval != 0) \
} \ return (retval); \
if (parentp != NULL) { \
parent = allocfn(ptree); \
if (__predict_false(parent == NULL)) { \
*found_out = NULL; \
return (ENOMEM); \
} \
pctrie_insert_node(parentp, parent, val); \
} \
found = pctrie_subtree_lookup_gt(neighbor, *val); \ found = pctrie_subtree_lookup_gt(neighbor, *val); \
*found_out = name##_PCTRIE_VAL2PTR(found); \ *found_out = name##_PCTRIE_VAL2PTR(found); \
pctrie_subtree_lookup_gt_assert(neighbor, *val, ptree, found); \ pctrie_subtree_lookup_gt_assert(neighbor, *val, ptree, found); \
return (0); \ return (0); \
} \ } \
\ \
static __inline __unused int \ static __inline __unused int \
name##_PCTRIE_INSERT_LOOKUP_LE(struct pctrie *ptree, struct type *ptr, \ name##_PCTRIE_INSERT_LOOKUP_LE(struct pctrie *ptree, struct type *ptr, \
struct type **found_out) \ struct type **found_out) \
{ \ { \
struct pctrie_node *parent, *neighbor; \ struct pctrie_node *neighbor; \
void *parentp; \ void *parentp; \
uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \ uint64_t *val = name##_PCTRIE_PTR2VAL(ptr); \
uint64_t *found; \ uint64_t *found; \
int retval; \
\ \
parentp = pctrie_insert_lookup_lt(ptree, val, &found, \ parentp = pctrie_insert_lookup_lt(ptree, val, &found, \
&neighbor); \ &neighbor); \
if (__predict_false(found != NULL)) { \ retval = name##_PCTRIE_INSERT_BASE(ptree, parentp, val, \
*found_out = name##_PCTRIE_VAL2PTR(found); \ found, found_out); \
return (EEXIST); \ if (retval != 0) \
} \ return (retval); \
if (parentp != NULL) { \
parent = allocfn(ptree); \
if (__predict_false(parent == NULL)) { \
*found_out = NULL; \
return (ENOMEM); \
} \
pctrie_insert_node(parentp, parent, val); \
} \
found = pctrie_subtree_lookup_lt(neighbor, *val); \ found = pctrie_subtree_lookup_lt(neighbor, *val); \
*found_out = name##_PCTRIE_VAL2PTR(found); \ *found_out = name##_PCTRIE_VAL2PTR(found); \
pctrie_subtree_lookup_lt_assert(neighbor, *val, ptree, found); \ pctrie_subtree_lookup_lt_assert(neighbor, *val, ptree, found); \
return (0); \ return (0); \
} \ } \
\ \
static __inline __unused struct type * \ static __inline __unused struct type * \
name##_PCTRIE_LOOKUP(struct pctrie *ptree, uint64_t key) \ name##_PCTRIE_LOOKUP(struct pctrie *ptree, uint64_t key) \
▲ Show 20 Lines • Show All 297 Lines • Show Last 20 Lines