Page MenuHomeFreeBSD
Differential D42590

devel/freebsd-gcc{9,12}: Various cleanups, no functional change
ClosedPublic
Actions

Authored by jhb on Nov 13 2023, 11:22 PM.
Tags
None
Referenced Files
F161501148: D42590.id130063.diff
Sat, Jul 4, 8:29 AM
F161488107: D42590.id.diff
Sat, Jul 4, 6:09 AM
F161407566: D42590.id130283.diff
Fri, Jul 3, 12:20 PM
Unknown Object (File)
Fri, Jul 3, 10:36 AM
Unknown Object (File)
Wed, Jul 1, 12:00 AM
Unknown Object (File)
Tue, Jun 23, 6:36 AM
Unknown Object (File)
Thu, Jun 18, 5:56 PM
Unknown Object (File)
Thu, Jun 18, 2:45 AM
View All Files
Subscribers
emaste

Details

Reviewers
fuz
Commits
R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change
Summary
  • Use DISTVERSION instead of PORTVERISON
  • Don't silence post-install commands to remove various files from the staging area
  • Simplify logic to handle arch-specific packing lists

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54414
Build 51304: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 13 2023, 11:22 PM
jhb created this revision.
Harbormaster completed remote builds in B54414: Diff 130063.Nov 13 2023, 11:22 PM
jhb added a comment.Nov 13 2023, 11:23 PM

Various changes inspired from the review of adding devel/freebsd-gcc13 in D42574.

jhb mentioned this in D42574: devel/freebsd-gcc13: External FreeBSD toolchain based on GCC 13..Nov 13 2023, 11:24 PM
jhb added a reviewer: fuz.Nov 14 2023, 12:45 AM
fuz accepted this revision.Nov 14 2023, 1:32 AM

LGTM as is, but see suggested improvement.

devel/freebsd-gcc12/Makefile
111–117

Perhaps?

This revision is now accepted and ready to land.Nov 14 2023, 1:32 AM
emaste added a subscriber: emaste.Nov 14 2023, 1:37 AM
jhb updated this revision to Diff 130283.Nov 17 2023, 10:22 PM

Additional fixes

This revision now requires review to proceed.Nov 17 2023, 10:22 PM
Harbormaster completed remote builds in B54502: Diff 130283.Nov 17 2023, 10:22 PM
fuz accepted this revision.Nov 19 2023, 10:30 PM

LGTM, but perhaps you could mention explicitly that it's for compiling the same FreeBSD version the host runs.

This revision is now accepted and ready to land.Nov 19 2023, 10:30 PM
Closed by commit R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change (authored by jhb). · Explain WhyNov 21 2023, 9:46 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: R11:5723f9adab52: devel/freebsd-gcc{9,12}: Various cleanups, no functional change.

Revision Contents
Changeset List

PathSize
devel/
freebsd-gcc12/
29 lines
pkg-plist.riscv64
pkg-plist.riscv
4 lines
freebsd-gcc9/
35 lines
pkg-plist.riscv64
pkg-plist.riscv
4 lines

Diff 130063

View Options

devel/freebsd-gcc12/Makefile

Loading...
View Options

devel/freebsd-gcc12/pkg-plist.riscv

Loading...
View Options

devel/freebsd-gcc12/pkg-plist.riscv64

Loading...
View Options

devel/freebsd-gcc9/Makefile

Loading...
View Options

devel/freebsd-gcc9/pkg-plist.riscv

Loading...
View Options

devel/freebsd-gcc9/pkg-plist.riscv64

Loading...