Differential D5181

Add defines for WRITE_UNCORRECTABLE ATA command, and improve command logging.
ClosedPublic
Actions

Authored by rpokala on Feb 4 2016, 1:58 AM.

Tags

None

Referenced Files

	F137080519: D5181.id12988.diff
	Fri, Nov 21, 2:46 AM

	F137075417: D5181.id13024.diff
	Fri, Nov 21, 2:30 AM

	F137073738: D5181.id.diff
	Fri, Nov 21, 2:25 AM

	F137072885: D5181.id12989.diff
	Fri, Nov 21, 2:23 AM

	F137072159: D5181.diff
	Fri, Nov 21, 2:21 AM

	Unknown Object (File)
	Thu, Nov 20, 3:45 AM

	Unknown Object (File)
	Mon, Nov 10, 1:20 PM

	Unknown Object (File)
	Tue, Nov 4, 9:52 PM

Subscribers

Details

Reviewers

imp
mav

Commits

rS295276: Add defines for WRITE_UNCORRECTABLE ATA command, and improve command logging

Summary

Add #defines for ATA_WRITE_UNCORRECTABLE48 and its features. Update the
decoding in ATACAM to recognize the new values. Also improve command
decoding for a few other commands (SMART, NOP, SET_FEATURES). Bring the
decoding in ata(4) up to parity with ATACAM.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2381
Build 2397: arc lint + arc unit

Event Timeline

rpokala updated this revision to Diff 12988.Feb 4 2016, 1:58 AM

rpokala retitled this revision from to Add defines for WRITE_UNCORRECTABLE ATA command, and improve command logging..

rpokala updated this object.

rpokala edited the test plan for this revision. (Show Details)

rpokala added a reviewer: mav.

Herald added a subscriber: imp. · View Herald TranscriptFeb 4 2016, 1:58 AM

Remove if_lagg.{c,h} from this review; they're from something else.

Looks good to me. I have no objections. Some commands mentioned there are obsolete now, but that is not really a problem.

This revision is now accepted and ready to land.Feb 4 2016, 12:04 PM

imp accepted this revision.Feb 4 2016, 6:33 PM

imp added a reviewer: imp.

Closed by commit rS295276: Add defines for WRITE_UNCORRECTABLE ATA command, and improve command logging (authored by rpokala). · Explain WhyFeb 4 2016, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

cam/

ata/

60 lines

dev/

ata/

100 lines

sys/

3 lines

Diff 12989

sys/cam/ata/ata_all.c

Loading...

sys/dev/ata/ata-all.c

Loading...

sys/sys/ata.h

Loading...