Rename some CPU_MIPSxxx options and add new CPU_MIPSxxx options
ClosedPublic
Actions

Authored by Sgalabov_gmail.com on Jan 26 2016, 10:41 AM.

Details

Reviewers

imp
adrian

Group Reviewers

MIPS

Commits

rS295138: Rename some CPU_MIPSxxx options and add new CPU_MIPSxxx options

Summary

This revision does the following renames:
CPU_MIPS24KC -> CPU_MIPS24K
CPU_MIPS74KC -> CPU_MIPS74K
CPU_MIPS1004KC -> CPU_MIPS1004K

It also adds the following new CPU_MIPSxxx options:
CPU_MIPS24KE, CPU_MIPS34K, CPU_MIPS1074K, CPU_INTERAPTIV, CPU_PROAPTIV

CPU_MIPSxxxxKC is limiting and possibly misleading as it implies the MIPSxxxxK CPU has no FPU.
It would be better if the CPUs are named after their standard functionalities only and the presence or absence of FPU can then be controlled via the CPU_HAVEFPU option.

I will send out another dependent revision that moves MIPS 32 r2 and r3 CPUs to use the EHB instruction for clearing hazards instead of NOP/SSNOP.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sgalabov_gmail.com updated this revision to Diff 12711.Jan 26 2016, 10:41 AM

Sgalabov_gmail.com retitled this revision from to Rename some CPU_MIPSxxx options and add new CPU_MIPSxxx options.

Sgalabov_gmail.com updated this object.

Sgalabov_gmail.com edited the test plan for this revision. (Show Details)

Sgalabov_gmail.com added a reviewer: MIPS.

Sgalabov_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.

Sgalabov_gmail.com added a project: MIPS.

Sgalabov_gmail.com added a subscriber: freebsd-mips-list.

Herald added a subscriber: imp. · View Herald TranscriptJan 26 2016, 10:41 AM

Sgalabov_gmail.com added reviewers: adrian, imp.Jan 26 2016, 10:43 AM

Sgalabov_gmail.com added a child revision: D5078: Move MIPS32 Release 2 and Release 3 CPUs to use the EHB instruction for clearing hazards.Jan 26 2016, 10:47 AM

Sgalabov_gmail.com added a child revision: D5079: Use the correct cpu option for rt305x hardware.Jan 26 2016, 10:51 AM

imp accepted this revision.Jan 27 2016, 6:02 AM

imp edited edge metadata.

This revision is now accepted and ready to land.Jan 27 2016, 6:02 AM

After discussion with imp@, removed the CPU_MIPS24KE option, as 24KE is not really different than 24K, apart from having DSP ASE, which can be detected dynamically via Config3 register.

This revision now requires review to proceed.Jan 27 2016, 7:47 AM

This fine by me; it reminds me that we never started using the mips24k pieces for those atheros SoC cores (all the ar71xx, ar91xx, ar933x, etc) that are actually mips24k. They're mips4k.

We can fix that later though!

I meant to talk to you about possibly moving the Atheros SoCs to MIPS24K, but then got distracted with other things :-)
Yeah, I guess we can move the SoCs later. I did that for the Ralink SoCs in sys/mips/ralink for now, will be using the new cpu options with the Ralink/Mediatek FDT stuff too.

Closed by commit rS295138: Rename some CPU_MIPSxxx options and add new CPU_MIPSxxx options (authored by adrian). · Explain WhyFeb 2 2016, 7:47 AM

This revision was automatically updated to reflect the committed changes.