Page MenuHomeFreeBSD
Differential D42072

Remove unneeded ca_root_nss dependency from Go ports.
Needs ReviewPublic
Actions

Authored by des on Oct 4 2023, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 5, 5:18 AM
Unknown Object (File)
Thu, Jul 3, 3:27 AM
Unknown Object (File)
Mon, Jun 30, 6:10 PM
Unknown Object (File)
Sat, Jun 28, 11:05 PM
Unknown Object (File)
Wed, Jun 25, 5:27 AM
Unknown Object (File)
Sun, Jun 22, 1:04 PM
Unknown Object (File)
Sun, Jun 22, 8:45 AM
Unknown Object (File)
Sat, Jun 21, 1:38 AM
View All Files
Subscribers
mat

Details

Reviewers
mfechner
iscandr_gmail.com
Group Reviewers
portmgr
Commits
R11:0573da1acf9f: www/gitlab-ce: remove ca_root_nss fetch dep for go ports
Summary

MFH: 2023Q4

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53872
Build 50763: arc lint + arc unit

Event Timeline

des created this revision.Oct 4 2023, 12:49 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptOct 4 2023, 12:49 PM
Herald added a subscriber: mat. · View Herald Transcript
des requested review of this revision.Oct 4 2023, 12:49 PM
Harbormaster completed remote builds in B53828: Diff 128216.Oct 4 2023, 12:49 PM
des updated this revision to Diff 128268.Oct 5 2023, 12:33 AM

rebase

Harbormaster completed remote builds in B53840: Diff 128268.Oct 5 2023, 12:33 AM
mfechner requested changes to this revision.Oct 6 2023, 12:15 PM

I tested only the ports I'm the maintainer, and it is fine.
Feel free to remove the ca_root_nss from them.

But please do not increase the PORTREVISION as this modification does not have any impact for users if they have already that version installed.

This revision now requires changes to proceed.Oct 6 2023, 12:15 PM
des updated this revision to Diff 128353.Oct 6 2023, 12:57 PM

leave PORTREVISION unchanged

Harbormaster completed remote builds in B53872: Diff 128353.Oct 6 2023, 12:57 PM
mfechner accepted this revision.Oct 6 2023, 1:20 PM

Thanks a lot for your work!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2023, 10:59 AM
Closed by commit R11:0573da1acf9f: www/gitlab-ce: remove ca_root_nss fetch dep for go ports (authored by mfechner). · Explain Why
This revision was automatically updated to reflect the committed changes.
mfechner added a commit: R11:0573da1acf9f: www/gitlab-ce: remove ca_root_nss fetch dep for go ports.
mfechner reopened this revision.Nov 1 2023, 11:01 AM

Not all is fixed here, just did modification related to gitlab

des updated this revision to Diff 129812.Nov 7 2023, 2:39 PM

rebase

Harbormaster completed remote builds in B54313: Diff 129812.Nov 7 2023, 2:39 PM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
3 lines
devel/
gitaly/
3 lines
gitlab-shell/
3 lines
security/
go-cve-dictionary/
2 lines
textproc/
gitlab-elasticsearch-indexer/
3 lines
www/
gitlab-workhorse/
3 lines

Diff 128353

View Options

Mk/Uses/go.mk

Loading...
View Options

devel/gitaly/Makefile

Loading...
View Options

devel/gitlab-shell/Makefile

Loading...
View Options

security/go-cve-dictionary/Makefile

Loading...
View Options

textproc/gitlab-elasticsearch-indexer/Makefile

Loading...
View Options

www/gitlab-workhorse/Makefile

Loading...