Details

Reviewers

tcberner
zirias

Commits

R11:9c67d516b56b: multimedia/motion: Update to 4.5.1

Summary

Changelogs:

4.5.1: https://github.com/Motion-Project/motion/releases/tag/release-4.5.1
4.5.0: https://github.com/Motion-Project/motion/releases/tag/release-4.5.0
4.4.0: https://github.com/Motion-Project/motion/releases/tag/release-4.4.0

PR: 273810

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53646
Build 50537: arc lint + arc unit

Event Timeline

jbo created this revision.Sep 19 2023, 1:23 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 19 2023, 1:23 PM

jbo requested review of this revision.Sep 19 2023, 1:23 PM

Harbormaster completed remote builds in B53642: Diff 127531.Sep 19 2023, 1:23 PM

Commit: Use author email as ident as well.

Harbormaster completed remote builds in B53643: Diff 127532.Sep 19 2023, 1:33 PM

Remove obsolete/unnecessary PORTREVISION.

Harbormaster completed remote builds in B53646: Diff 127537.Sep 19 2023, 4:41 PM

zirias added inline comments.Sep 19 2023, 4:52 PM

multimedia/motion/Makefile
3	Please drop this on DISTVERSION updates
30	Did you check whether the new version still needs "legacy" ffmpeg?
91	Did you check whether this is still needed? Otherwise might be an opportunity to drop autoreconf...
96	autotools-based projects normally come with a working `make install` -- do we really need this custom recipe?

Took some back-and-forth with the submitter but unless I'm missing something obvious this should be acceptable now.

Harbormaster completed remote builds in B53722: Diff 127810.Sep 25 2023, 11:25 PM

zirias added inline comments.Sep 26 2023, 6:01 AM

multimedia/motion/Makefile
65	I would assume a simple `--with-ffmpeg` should be enough now, without the path. If so, coud replace both lines simply by `FFMPEG_CONFIGURE_WITH= ffmpeg`. Maybe some other options could also be simplified in a similar way.