tcpdump: Initialize tzcode early.
ClosedPublic
Actions

Authored by des on Sep 15 2023, 8:09 PM.

Details

Reviewers

Commits

rGc1b6110df040: tcpdump: Initialize tzcode early.
rG51d54ed6151b: tcpdump: Initialize tzcode early.
rG7e0a7ef95fac: tcpdump: Initialize tzcode early.

Summary

An explicit tzset() call is usually not needed as it happens implicitly
the first time we call localtime() or mktime(), but in some cases
(sandboxing, chroot) this may be too late.

PR: 273807
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53610
Build 50501: arc lint + arc unit

Event Timeline

des created this revision.Sep 15 2023, 8:09 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 15 2023, 8:09 PM

des requested review of this revision.Sep 15 2023, 8:09 PM

Harbormaster completed remote builds in B53610: Diff 127440.Sep 15 2023, 8:09 PM

Looks good. On my CURRENT system (main-n265074-6b635c74fd41), the log entries are now displayed in local time. Thank you.

This revision is now accepted and ready to land.Sep 15 2023, 8:33 PM

Closed by commit rG7e0a7ef95fac: tcpdump: Initialize tzcode early. (authored by des). · Explain WhySep 15 2023, 9:37 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG7e0a7ef95fac: tcpdump: Initialize tzcode early..

des added a commit: rG51d54ed6151b: tcpdump: Initialize tzcode early..Sep 19 2023, 10:31 AM

des added a commit: rGc1b6110df040: tcpdump: Initialize tzcode early..Sep 19 2023, 10:47 AM

Revision Contents
Changeset List

Path

Size

contrib/

tcpdump/

tcpdump.c

2 lines

Diff 127440

View Options

tcpdump: Initialize tzcode early.ClosedPublicActions