Paths

Table of Contentst

Differential D41862

misc/retry: Add new port
ClosedPublic
Actions

Authored by jbo on Sep 14 2023, 4:02 PM.

Tags

None

Referenced Files

	F87422007: D41862.id127422.diff
	Tue, Jul 2, 8:23 PM

	F87421008: D41862.id127416.diff
	Tue, Jul 2, 8:06 PM

	F87420954: D41862.id127417.diff
	Tue, Jul 2, 8:05 PM

	F87419405: D41862.id127392.diff
	Tue, Jul 2, 7:49 PM

	Unknown Object (File)
	Sun, Jun 30, 11:54 PM

	Unknown Object (File)
	Sat, Jun 29, 12:58 AM

	Unknown Object (File)
	May 28 2024, 12:05 PM

	Unknown Object (File)
	May 17 2024, 11:43 AM

View All 47 Files

Subscribers

Details

Reviewers

tcberner
zirias

Commits

R11:c046a1681579: misc/retry: Add new port

Summary

A utility to retry a command until the command succeeds

PR: 273730

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53588
Build 50479: arc lint + arc unit

Event Timeline

jbo created this revision.Sep 14 2023, 4:02 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 14 2023, 4:02 PM

jbo requested review of this revision.Sep 14 2023, 4:02 PM

Harbormaster completed remote builds in B53588: Diff 127392.Sep 14 2023, 4:02 PM

diizzy added a subscriber: diizzy.Sep 14 2023, 5:23 PM

diizzy added inline comments.

misc/retry/Makefile
10	Please also define LICENSE_FILE
12	There's a man page in the tarball already?
14	Is autoreconf really needed?
16	You probably want GNU_CONFIGURE here as it's not a custom configure script

Thanks @diizzy, agree with everything. Just to clarify, some of these seem to be remains from a first version of the patch in the PR that used USE_GITHUB although there is a proper distfile ;)

Update Makefile as requested.

However, unless I am being blind, the distfile does not include
a license file suitable for LICENSE_FILE?

Harbormaster completed remote builds in B53596: Diff 127416.Sep 15 2023, 12:28 PM

Found the license file... sorry for the noise :D

Harbormaster completed remote builds in B53597: Diff 127417.Sep 15 2023, 12:29 PM

lgtm

This revision is now accepted and ready to land.Sep 15 2023, 1:12 PM

Closed by commit R11:c046a1681579: misc/retry: Add new port (authored by Jon Stuart <freebsd@zikomo.xyz>, committed by jbo). · Explain WhySep 15 2023, 1:52 PM

This revision was automatically updated to reflect the committed changes.

jbo added a commit: R11:c046a1681579: misc/retry: Add new port.

Revision Contents
Changeset List

Path

Size

misc/

1 line

retry/

21 lines

3 lines

8 lines

Diff 127392

misc/Makefile

Loading...

misc/retry/Makefile

Loading...

misc/retry/distinfo

Loading...

misc/retry/pkg-descr

Loading...