Differential D41733

time.h: Fix visibility check for C11 and C23 features.
ClosedPublic
Actions

Authored by des on Sep 5 2023, 3:09 PM.

Tags

None

Referenced Files

	F153144456: D41733.id.diff
	Sun, Apr 19, 11:17 AM

	Unknown Object (File)
	Fri, Apr 17, 11:22 PM

	Unknown Object (File)
	Fri, Apr 17, 7:48 PM

	Unknown Object (File)
	Wed, Apr 15, 10:51 PM

	Unknown Object (File)
	Tue, Apr 7, 8:57 AM

	Unknown Object (File)
	Thu, Apr 2, 12:42 AM

	Unknown Object (File)
	Wed, Apr 1, 10:01 PM

	Unknown Object (File)
	Mar 17 2026, 7:18 PM

Subscribers

Details

Reviewers

brooks
imp

Commits

rG8444b3642001: time.h: Fix visibility check for C11 and C23 features.
rGcd5a2e6b4369: time.h: Fix visibility check for C11 and C23 features.
rG8091b82e2916: time.h: Fix visibility check for C11 and C23 features.

Summary

__BSD_VISIBLE is always defined; we need to check if it's true.

Fixes: d02489d11aed 9b5d724cad10

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 5 2023, 3:09 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2023, 3:09 PM

des requested review of this revision.Sep 5 2023, 3:09 PM

Harbormaster completed remote builds in B53438: Diff 126887.Sep 5 2023, 3:09 PM

Looks correct

This revision is now accepted and ready to land.Sep 5 2023, 6:19 PM

Might want to grep elsewhere fir this pattern :)

In D41733#951046, @imp wrote:

Might want to grep elsewhere fir this pattern :)

Did that earlier today, nothing else stuck out, let me know if you find something.

Closed by commit rG8091b82e2916: time.h: Fix visibility check for C11 and C23 features. (authored by des). · Explain WhySep 6 2023, 1:38 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG8091b82e2916: time.h: Fix visibility check for C11 and C23 features..

des added a commit: rGcd5a2e6b4369: time.h: Fix visibility check for C11 and C23 features..Sep 7 2023, 8:29 PM

des added a commit: rG8444b3642001: time.h: Fix visibility check for C11 and C23 features..Sep 14 2023, 3:03 PM

Revision Contents
Changeset List

Path

Size

include/

4 lines

Diff 126928

include/time.h

Loading...