Page MenuHomeFreeBSD
Differential D41418

sesutil: Complete libxo transition.
ClosedPublic
Actions

Authored by yanhaowang on Aug 10 2023, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 4, 5:30 PM
Unknown Object (File)
Tue, Nov 4, 5:29 PM
Unknown Object (File)
Tue, Nov 4, 5:26 PM
Unknown Object (File)
Tue, Nov 4, 5:23 PM
Unknown Object (File)
Tue, Nov 4, 5:23 PM
Unknown Object (File)
Tue, Nov 4, 5:22 PM
Unknown Object (File)
Tue, Nov 4, 10:37 AM
Unknown Object (File)
Sun, Nov 2, 9:22 AM
View All Files
Subscribers
imp

Details

Reviewers
lwhsu
des
Commits
rG3d1b233e039d: sesutil(8): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53041
Build 49932: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Aug 10 2023, 11:34 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 11:34 PM
yanhaowang requested review of this revision.Aug 10 2023, 11:34 PM
Harbormaster completed remote builds in B53041: Diff 125851.Aug 10 2023, 11:34 PM
yanhaowang added reviewers: lwhsu, des.Aug 10 2023, 11:34 PM
yanhaowang updated this revision to Diff 125904.Aug 12 2023, 2:24 AM
  • Remove unnecessary space line.
Harbormaster completed remote builds in B53067: Diff 125904.Aug 12 2023, 2:24 AM
des requested changes to this revision.Aug 17 2023, 3:20 PM
des added inline comments.
usr.sbin/sesutil/sesutil.c
103

This is never called with out set to anything other than stderr, so out can be dropped and the fprintf() calls can be replaced with xo_error().

108

s/Usage/usage/

115

s/Usage/usage/

This revision now requires changes to proceed.Aug 17 2023, 3:20 PM
yanhaowang updated this revision to Diff 126258.Aug 20 2023, 7:39 AM
  • Change usage function.
  • Use EXIT_ string style.
Harbormaster completed remote builds in B53188: Diff 126258.Aug 20 2023, 7:39 AM
yanhaowang marked 3 inline comments as done.Aug 20 2023, 7:40 AM
des accepted this revision.Aug 26 2023, 11:51 PM
This revision is now accepted and ready to land.Aug 26 2023, 11:51 PM
Closed by commit rG3d1b233e039d: sesutil(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:30 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG3d1b233e039d: sesutil(8): Complete libxo transition.

Revision Contents
Changeset List

PathSize
usr.sbin/
sesutil/
2 lines
19 lines

Diff 125851

View Options

usr.sbin/sesutil/eltsub.c

Loading...
View Options

usr.sbin/sesutil/sesutil.c

Loading...