Page MenuHomeFreeBSD
Differential D41414

lastlogin: Complete libxo transition.
ClosedPublic
Actions

Authored by yanhaowang on Aug 10 2023, 10:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 16, 3:13 AM
Unknown Object (File)
Wed, Apr 15, 11:15 PM
Unknown Object (File)
Tue, Apr 14, 10:50 PM
Unknown Object (File)
Tue, Apr 14, 7:43 AM
Unknown Object (File)
Tue, Apr 14, 6:38 AM
Unknown Object (File)
Tue, Apr 14, 5:46 AM
Unknown Object (File)
Sat, Apr 11, 2:39 PM
Unknown Object (File)
Fri, Apr 10, 11:20 PM
View All Files
Subscribers
guest-patmaddox
imp

Details

Reviewers
lwhsu
des
Commits
rG7d5fd25ab8f5: lastlogin(8): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53039
Build 49930: arc lint + arc unit

Event Timeline

yanhaowang created this revision.Aug 10 2023, 10:57 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 10:57 PM
yanhaowang requested review of this revision.Aug 10 2023, 10:57 PM
Harbormaster completed remote builds in B53039: Diff 125828.Aug 10 2023, 10:57 PM
yanhaowang added reviewers: lwhsu, des.Aug 10 2023, 10:58 PM
yanhaowang updated this revision to Diff 125902.Aug 12 2023, 2:19 AM
  • Remove unnecessary space line.
Harbormaster completed remote builds in B53065: Diff 125902.Aug 12 2023, 2:19 AM
des requested changes to this revision.Aug 17 2023, 3:09 PM
des added inline comments.
usr.sbin/lastlogin/lastlogin.c
149

The indentation here seems wrong.

172–174

There is no need to call xo_finish() here, since we haven't emitted anything.

This revision now requires changes to proceed.Aug 17 2023, 3:09 PM
yanhaowang updated this revision to Diff 126293.Aug 21 2023, 12:30 PM
  • Remove unnecessary xo_finish function.
  • Use number style.
Harbormaster completed remote builds in B53199: Diff 126293.Aug 21 2023, 12:30 PM
yanhaowang marked 2 inline comments as done.Aug 21 2023, 12:31 PM
des accepted this revision.Aug 26 2023, 11:49 PM
This revision is now accepted and ready to land.Aug 26 2023, 11:49 PM
guest-patmaddox added a subscriber: guest-patmaddox.Oct 19 2023, 9:46 PM
Closed by commit rG7d5fd25ab8f5: lastlogin(8): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:30 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rG7d5fd25ab8f5: lastlogin(8): Complete libxo transition.

Revision Contents
Changeset List

PathSize
usr.sbin/
lastlogin/
14 lines

Diff 125828

View Options

usr.sbin/lastlogin/lastlogin.c

Loading...