Differential D5025

Various style fixes.
ClosedPublic
Actions

Authored by jhb on Jan 22 2016, 12:11 AM.

Details

Reviewers

kib

Commits

rS294851: Various style fixes.

Summary

Various style fixes.

Wrap long lines.
Fix indentation.
Remove excessive parens.
Whitespace fixes in struct definitions.

This is probably not exhaustive, but it hits some of them. I kept the
'struct<tab>foo bar' style since it was far more dominant in this file
compared to 'struct foo<tab>bar'.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2222
Build 2231: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 12576.Jan 22 2016, 12:11 AM

jhb retitled this revision from to Various style fixes..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2016, 12:11 AM

kib accepted this revision.Jan 22 2016, 3:32 AM

kib edited edge metadata.

kib added inline comments.

sys/kern/vfs_aio.c
144	Bruce (strongly) suggests to put description string on the new line, even if previous line is under-filled.

This revision is now accepted and ready to land.Jan 22 2016, 3:32 AM

jhb added inline comments.Jan 26 2016, 9:18 PM

sys/kern/vfs_aio.c
144	Ok, I will fix all of them that aren't and commit.

Put each sysctl description on its own line.

This revision now requires review to proceed.Jan 26 2016, 9:18 PM

Closed by commit rS294851: Various style fixes. (authored by jhb). · Explain WhyJan 26 2016, 9:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_aio.c

68 lines

Diff 12576

View Options

Various style fixes.ClosedPublicActions