opencrypto: Respect alignment constraints in xor_and_encrypt()
ClosedPublic
Actions

Authored by markj on Jul 27 2023, 3:11 PM.

Details

Reviewers

Commits

rG045fc75ce490: opencrypto: Respect alignment constraints in xor_and_encrypt()
rG96c253812139: opencrypto: Respect alignment constraints in xor_and_encrypt()

Summary

Copy operands to an aligned buffer before performing operations which
require alignment. Otherwise it's possible for this code to trigger an
alignment fault on armv7.

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52868
Build 49759: arc lint + arc unit

Event Timeline

markj created this revision.Jul 27 2023, 3:11 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 27 2023, 3:11 PM

markj requested review of this revision.Jul 27 2023, 3:11 PM

Harbormaster completed remote builds in B52868: Diff 125246.Jul 27 2023, 3:11 PM

jhb accepted this revision.Jul 27 2023, 3:36 PM

This revision is now accepted and ready to land.Jul 27 2023, 3:36 PM

Closed by commit rG96c253812139: opencrypto: Respect alignment constraints in xor_and_encrypt() (authored by markj). · Explain WhyJul 27 2023, 8:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG96c253812139: opencrypto: Respect alignment constraints in xor_and_encrypt().

markj added a commit: rG045fc75ce490: opencrypto: Respect alignment constraints in xor_and_encrypt().Aug 24 2023, 1:41 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

cbc_mac.c

19 lines

Diff 125246

View Options

opencrypto: Respect alignment constraints in xor_and_encrypt()ClosedPublicActions