Paths

Table of Contentst

Differential D40985

kinst: exclude cpu_switch
ClosedPublic
Actions

Authored by christos on Jul 12 2023, 1:25 PM.

Details

Reviewers

markj

Commits

rGeb1413c9a6c7: kinst: exclude cpu_switch

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52619
Build 49510: arc lint + arc unit

Event Timeline

christos created this revision.Jul 12 2023, 1:25 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2023, 1:25 PM

christos requested review of this revision.Jul 12 2023, 1:25 PM

Harbormaster completed remote builds in B52577: Diff 124540.Jul 12 2023, 1:25 PM

cpu_switch() was able to be traced in arm64 and riscv, and as is expected, resulted in crashes.

markj added inline comments.Jul 13 2023, 5:53 PM

sys/cddl/dev/kinst/kinst.c
99	Please add a comment explaining why: cpu_switch() modifies the value of `curthread`, but kinst_invop() assumes that this won't happen.

Explain why

Harbormaster completed remote builds in B52619: Diff 124614.Jul 13 2023, 6:05 PM

Approved.

This revision is now accepted and ready to land.Jul 13 2023, 6:34 PM

Closed by commit rGeb1413c9a6c7: kinst: exclude cpu_switch (authored by christos). · Explain WhyJul 19 2023, 3:00 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGeb1413c9a6c7: kinst: exclude cpu_switch.

Revision Contents
Changeset List

Path

Size

sys/

cddl/

dev/

kinst/

amd64/

kinst_isa.c

5 lines

kinst.c

7 lines

Diff 124614

View Options

sys/cddl/dev/kinst/amd64/kinst_isa.c