Page MenuHomeFreeBSD
Differential D40760

dhclient: fix time parsing for leases expiring after 2038
ClosedPublic
Actions

Authored by alexander.bahm_dell.com on Jun 26 2023, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 2, 3:06 PM
Unknown Object (File)
Sat, Aug 2, 2:20 PM
Unknown Object (File)
Fri, Aug 1, 8:39 PM
Unknown Object (File)
Thu, Jul 24, 5:30 PM
Unknown Object (File)
Wed, Jul 23, 4:09 PM
Unknown Object (File)
Jun 24 2025, 2:17 PM
Unknown Object (File)
Jun 23 2025, 5:55 PM
Unknown Object (File)
Jun 23 2025, 7:38 AM
View All 80 Files
Subscribers
None

Details

Reviewers
imp
markj
vangyzen
Commits
rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038
Summary

Convert lease parsing to timegm to calculate timestamp. For reference, when
writing the lease, we use gmtime to convert the timestamp to struct tm.

MFC after: 2 weeks
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alexander.bahm_dell.com requested review of this revision.Jun 26 2023, 7:50 PM
alexander.bahm_dell.com created this revision.
Harbormaster completed remote builds in B52291: Diff 123794.Jun 26 2023, 7:50 PM
markj accepted this revision.Jun 27 2023, 2:28 PM
markj added inline comments.
sbin/dhclient/tests/option-domain-search.c
337
This revision is now accepted and ready to land.Jun 27 2023, 2:28 PM
alexander.bahm_dell.com updated this revision to Diff 123864.Jun 27 2023, 8:36 PM

Addressed feedback

This revision now requires review to proceed.Jun 27 2023, 8:36 PM
Harbormaster completed remote builds in B52304: Diff 123864.Jun 27 2023, 8:36 PM
vangyzen accepted this revision.Jul 10 2023, 3:52 PM
This revision is now accepted and ready to land.Jul 10 2023, 3:52 PM
Closed by commit rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038 (authored by alexander.bahm_dell.com, committed by vangyzen). · Explain WhyJul 10 2023, 4:02 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038.

Revision Contents
Changeset List

PathSize
sbin/
dhclient/
28 lines
tests/
3 lines
15 lines
45 lines

Diff 124444

View Options

sbin/dhclient/parse.c

Loading...
View Options

sbin/dhclient/tests/Makefile

Loading...
View Options

sbin/dhclient/tests/fake.c

Loading...
View Options

sbin/dhclient/tests/option-domain-search.c

Loading...