Page MenuHomeFreeBSD
Differential D4862

Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp.
ClosedPublic
Actions

Authored by asomers on Jan 11 2016, 9:37 PM.
Tags
None
Referenced Files
F137026709: D4862.diff
Fri, Nov 21, 12:30 AM
Unknown Object (File)
Fri, Nov 14, 12:51 AM
Unknown Object (File)
Fri, Nov 14, 12:03 AM
Unknown Object (File)
Wed, Nov 12, 3:59 AM
Unknown Object (File)
Wed, Nov 12, 1:05 AM
Unknown Object (File)
Tue, Nov 11, 1:13 AM
Unknown Object (File)
Thu, Nov 6, 8:26 PM
Unknown Object (File)
Wed, Nov 5, 12:16 PM
View All Files
Subscribers
imp

Details

Reviewers
jilles
Commits
rS294347: Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp.
Summary

Use simmutable instead of uimmutable in the bad_truncate test. The former
is supported by both ZFS and UFS, but the latter only by UFS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2173
Build 2182: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 12127.Jan 11 2016, 9:37 PM
asomers retitled this revision from to Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: jilles.
Herald added a subscriber: imp. · View Herald TranscriptJan 11 2016, 9:37 PM
jilles edited edge metadata.Jan 15 2016, 8:39 PM

This adds a requirement that the test be run as root and that securelevel be -1 or 0, which may not be desirable. To prevent compatibility problems, a line

TEST_METADATA.truncate_test+=  required_user="root"

should be added to usr.bin/truncate/tests/Makefile.

Alternatively, file permissions (chmod 444) instead of file flags could be used. This requires

TEST_METADATA.truncate_test+=  required_user="unprivileged"

and the expected error message should be Permission denied instead of Operation not permitted.

asomers updated this revision to Diff 12424.Jan 18 2016, 4:10 PM
asomers edited edge metadata.

Address feedback from jilles: Use permissions instead of flags in bad_truncate

jilles accepted this revision.Jan 19 2016, 10:02 PM
jilles edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jan 19 2016, 10:02 PM
Closed by commit rS294347: Fix usr.bin.truncate.truncate_test.bad_truncate with ZFS /tmp. (authored by asomers). · Explain WhyJan 19 2016, 10:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
usr.bin/
truncate/
tests/
11 lines

Diff 12424

View Options

usr.bin/truncate/tests/truncate_test.sh

Loading...