You are changing the license from CDDL (i.e., derived from illumos dtrace code) to BSD. I believe the correct change would be to retain the existing license and simply add the foundation's copyright.

In D40875#930131, @markj wrote:

You are changing the license from CDDL (i.e., derived from illumos dtrace code) to BSD. I believe the correct change would be to retain the existing license and simply add the foundation's copyright.

Does it matter in this case since the software has been written from scratch? I've no problem with retaining the license however.

In D40875#930139, @christos wrote:

In D40875#930131, @markj wrote:

You are changing the license from CDDL (i.e., derived from illumos dtrace code) to BSD. I believe the correct change would be to retain the existing license and simply add the foundation's copyright.

Does it matter in this case since the software has been written from scratch? I've no problem with retaining the license however.

At least kinst.* was derived from an existing CDDL-licensed provider, so I think it's not so clear-cut. I would keep that file CDDL-licensed. kinst_isa.* and trampoline.* could be relicensed, but I'll leave it up to you.

Please at least add the proper SPDX-LICENSE-IDENTIFIER line. Consider omitting the boilerplate entirely: it's not needed and often wrong. I can work with the FF if they require the boilerplate since that's a policy that's not well aligned with the direction of yhe project and no longer the preferred license.

Did you replace all the copyrightable elements? What has been retained from before (I can't tell from this commit). We're the changes transformative?

In D40875#930146, @markj wrote:

At least kinst.* was derived from an existing CDDL-licensed provider, so I think it's not so clear-cut. I would keep that file CDDL-licensed. kinst_isa.* and trampoline.* could be relicensed, but I'll leave it up to you.

I can retain the original license, I don't really mind at all to be honest.