Page MenuHomeFreeBSD

Ignore NO_PACKAGE when PACKAGE_BUILDING is set
ClosedPublic

Authored by antoine on Aug 22 2014, 6:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 4:33 AM
Unknown Object (File)
Thu, Jan 16, 1:10 AM
Unknown Object (File)
Mon, Jan 13, 1:52 PM
Unknown Object (File)
Mon, Jan 13, 1:51 PM
Unknown Object (File)
Jan 6 2025, 10:30 PM
Unknown Object (File)
Jan 5 2025, 5:20 AM
Unknown Object (File)
Jan 4 2025, 10:08 PM
Unknown Object (File)
Jan 3 2025, 10:58 PM
Subscribers
None

Details

Summary

Ignore NO_PACKAGE when PACKAGE_BUILDING is set
People can still bypass using FORCE_PACKAGE (or not setting NO_FORCE_PACKAGE in poudriere.conf)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

antoine retitled this revision from to Ignore NO_PACKAGE when PACKAGE_BUILDING is set.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine added a reviewer: bdrewery.
bdrewery edited edge metadata.

Seems fine to me

This revision is now accepted and ready to land.Aug 23 2014, 5:15 PM
antoine edited edge metadata.

Move where all the IGNORE handling is done

Yeah. My only comment now is that something that is not packageable won't have its distfile mirrored. I am willing to accept that though.

Some of these are kind of ridiculous IMHO:

emulators/its/Makefile:NO_PACKAGE= PI ITS RP06 disk image is too big.
games/HeroesOfMightAndMagic/Makefile:NO_PACKAGE= Software is commercial
games/atitd/Makefile:NO_PACKAGE= Not packagable.
games/crafty-open-enormous/Makefile:NO_PACKAGE= Package is way too big
games/crafty-tablebase-no-pawn/Makefile:NO_PACKAGE= Way too big
games/crafty-tablebase-pawn/Makefile:NO_PACKAGE= Way too big
games/frogatto/Makefile:NO_PACKAGE= Package will be 144M, set FORCE_PACKAGE if you really want it
games/jaggedalliance2/Makefile:NO_PACKAGE= Language of the datafiles must be hardcoded in the game binary
games/linux-etqw-demo-server/Makefile:NO_PACKAGE= Package will be 428MB, set FORCE_PACKAGE if you really want it
games/linux-etqw-server/Makefile:NO_PACKAGE= Package will be 435MB, set FORCE_PACKAGE if you really want it
games/linux-quake4/Makefile:NO_PACKAGE= Package will be 280MB, set FORCE_PACKAGE if you really want it
games/linux-savage/Makefile:NO_PACKAGE= Package will be 150MB, set FORCE_PACKAGE if you really want it
games/linux-sof/Makefile:NO_PACKAGE= Distribution is 448MB; set FORCE_PACKAGE if you really want\
games/linux-ssamtfe/Makefile:NO_PACKAGE= Distribution is 279MB; set FORCE_PACKAGE if you really want\
games/linux-ssamtse/Makefile:NO_PACKAGE= Distribution is 352MB; set FORCE_PACKAGE if you really want to build this package
games/linux-unrealgold/Makefile:NO_PACKAGE= Distribution is 131MB; set FORCE_PACKAGE if you really want\
games/linux-ut/Makefile:NO_PACKAGE= Distribution is 340MB; set FORCE_PACKAGE if you really want\
games/quake3-ut/Makefile:NO_PACKAGE= package will be 445MB, set FORCE_PACKAGE if you really want it
games/quake3-wfa/Makefile:NO_PACKAGE= package will be 200MB, set FORCE_PACKAGE if you really want it

...

antoine updated this revision to Diff 1240.

Closed by commit rP365802 (authored by @antoine).