Page MenuHomeFreeBSD
Differential D670

Ignore NO_PACKAGE when PACKAGE_BUILDING is set
ClosedPublic
Actions

Authored by antoine on Aug 22 2014, 6:31 AM.
Tags
None
Referenced Files
F106126581: D670.diff
Wed, Dec 25, 8:20 PM
Unknown Object (File)
Tue, Dec 10, 8:22 PM
Unknown Object (File)
Thu, Dec 5, 7:48 PM
Unknown Object (File)
Thu, Dec 5, 7:47 PM
Unknown Object (File)
Thu, Dec 5, 7:46 PM
Unknown Object (File)
Nov 25 2024, 3:28 PM
Unknown Object (File)
Nov 18 2024, 1:20 PM
Unknown Object (File)
Nov 1 2024, 2:03 AM
View All Files
Subscribers
None

Details

Reviewers
bdrewery
Group Reviewers
portmgr
Commits
rP366339: MFH: r365802
rP365802: Ignore ports setting NO_PACKAGE when PACKAGE_BUILDING is set
Summary

Ignore NO_PACKAGE when PACKAGE_BUILDING is set
People can still bypass using FORCE_PACKAGE (or not setting NO_FORCE_PACKAGE in poudriere.conf)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

antoine updated this revision to Diff 1207.Aug 22 2014, 6:31 AM
antoine retitled this revision from to Ignore NO_PACKAGE when PACKAGE_BUILDING is set.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine added a reviewer: bdrewery.
Herald added a reviewer: portmgr. · View Herald TranscriptAug 22 2014, 6:31 AM
bdrewery accepted this revision.Aug 23 2014, 5:15 PM
bdrewery edited edge metadata.

Seems fine to me

This revision is now accepted and ready to land.Aug 23 2014, 5:15 PM
antoine updated this revision to Diff 1238.Aug 23 2014, 7:29 PM
antoine edited edge metadata.

Move where all the IGNORE handling is done

bdrewery added a comment.Aug 23 2014, 7:34 PM

Yeah. My only comment now is that something that is not packageable won't have its distfile mirrored. I am willing to accept that though.

Some of these are kind of ridiculous IMHO:

emulators/its/Makefile:NO_PACKAGE= PI ITS RP06 disk image is too big.
games/HeroesOfMightAndMagic/Makefile:NO_PACKAGE= Software is commercial
games/atitd/Makefile:NO_PACKAGE= Not packagable.
games/crafty-open-enormous/Makefile:NO_PACKAGE= Package is way too big
games/crafty-tablebase-no-pawn/Makefile:NO_PACKAGE= Way too big
games/crafty-tablebase-pawn/Makefile:NO_PACKAGE= Way too big
games/frogatto/Makefile:NO_PACKAGE= Package will be 144M, set FORCE_PACKAGE if you really want it
games/jaggedalliance2/Makefile:NO_PACKAGE= Language of the datafiles must be hardcoded in the game binary
games/linux-etqw-demo-server/Makefile:NO_PACKAGE= Package will be 428MB, set FORCE_PACKAGE if you really want it
games/linux-etqw-server/Makefile:NO_PACKAGE= Package will be 435MB, set FORCE_PACKAGE if you really want it
games/linux-quake4/Makefile:NO_PACKAGE= Package will be 280MB, set FORCE_PACKAGE if you really want it
games/linux-savage/Makefile:NO_PACKAGE= Package will be 150MB, set FORCE_PACKAGE if you really want it
games/linux-sof/Makefile:NO_PACKAGE= Distribution is 448MB; set FORCE_PACKAGE if you really want\
games/linux-ssamtfe/Makefile:NO_PACKAGE= Distribution is 279MB; set FORCE_PACKAGE if you really want\
games/linux-ssamtse/Makefile:NO_PACKAGE= Distribution is 352MB; set FORCE_PACKAGE if you really want to build this package
games/linux-unrealgold/Makefile:NO_PACKAGE= Distribution is 131MB; set FORCE_PACKAGE if you really want\
games/linux-ut/Makefile:NO_PACKAGE= Distribution is 340MB; set FORCE_PACKAGE if you really want\
games/quake3-ut/Makefile:NO_PACKAGE= package will be 445MB, set FORCE_PACKAGE if you really want it
games/quake3-wfa/Makefile:NO_PACKAGE= package will be 200MB, set FORCE_PACKAGE if you really want it

...

antoine updated this revision to Diff 1239.Aug 23 2014, 7:49 PM

Nicer message

antoine closed this revision.Aug 23 2014, 8:05 PM
antoine updated this revision to Diff 1240.

Closed by commit rP365802 (authored by @antoine).

Revision Contents
Changeset List

PathSize
Mk/
2 lines

Diff 1238

View Options

Mk/bsd.port.mk

Loading...