Page MenuHomeFreeBSD
Differential D40760

dhclient: fix time parsing for leases expiring after 2038
ClosedPublic
Actions

Authored by alexander.bahm_dell.com on Jun 26 2023, 7:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2025, 12:43 AM
Unknown Object (File)
Jan 30 2025, 1:01 PM
Unknown Object (File)
Dec 27 2024, 1:09 PM
Unknown Object (File)
Nov 15 2024, 1:30 PM
Unknown Object (File)
Nov 15 2024, 1:28 PM
Unknown Object (File)
Nov 15 2024, 12:03 PM
Unknown Object (File)
Nov 7 2024, 2:45 AM
Unknown Object (File)
Nov 7 2024, 2:45 AM
View All 58 Files
Subscribers
None

Details

Reviewers
imp
markj
vangyzen
Commits
rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038
Summary

Convert lease parsing to timegm to calculate timestamp. For reference, when
writing the lease, we use gmtime to convert the timestamp to struct tm.

MFC after: 2 weeks
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52304
Build 49195: arc lint + arc unit

Event Timeline

alexander.bahm_dell.com requested review of this revision.Jun 26 2023, 7:50 PM
alexander.bahm_dell.com created this revision.
Harbormaster completed remote builds in B52291: Diff 123794.Jun 26 2023, 7:50 PM
markj accepted this revision.Jun 27 2023, 2:28 PM
markj added inline comments.
sbin/dhclient/tests/option-domain-search.c
337
This revision is now accepted and ready to land.Jun 27 2023, 2:28 PM
alexander.bahm_dell.com updated this revision to Diff 123864.Jun 27 2023, 8:36 PM

Addressed feedback

This revision now requires review to proceed.Jun 27 2023, 8:36 PM
Harbormaster completed remote builds in B52304: Diff 123864.Jun 27 2023, 8:36 PM
vangyzen accepted this revision.Jul 10 2023, 3:52 PM
This revision is now accepted and ready to land.Jul 10 2023, 3:52 PM
Closed by commit rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038 (authored by alexander.bahm_dell.com, committed by vangyzen). · Explain WhyJul 10 2023, 4:02 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rGc210cac00f25: dhclient: fix time parsing for leases expiring after 2038.

Revision Contents
Changeset List

PathSize
sbin/
dhclient/
28 lines
tests/
3 lines
15 lines
45 lines

Diff 123864

View Options

sbin/dhclient/parse.c

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines
View Options

sbin/dhclient/tests/Makefile

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines
View Options

sbin/dhclient/tests/fake.c

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines
View Options

sbin/dhclient/tests/option-domain-search.c

Show First 20 Lines • Show All 409 Lines • ▼ Show 20 Lines
FILE *funopen(const void *, FILE *funopen(const void *,
int (* _Nullable)(void *, char *, int), int (* _Nullable)(void *, char *, int),
int (* _Nullable)(void *, const char *, int), int (* _Nullable)(void *, const char *, int),
fpos_t (* _Nullable)(void *, fpos_t, int), fpos_t (* _Nullable)(void *, fpos_t, int),
int (* _Nullable)(void *)); int (* _Nullable)(void *));
#define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0) #define fropen(cookie, fn) funopen(cookie, fn, 0, 0, 0)
#define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0) #define fwopen(cookie, fn) funopen(cookie, 0, fn, 0, 0)
#if __BSD_VISIBLE
typedef __ssize_t cookie_read_function_t(void *, char *, size_t); typedef __ssize_t cookie_read_function_t(void *, char *, size_t);
typedef __ssize_t cookie_write_function_t(void *, const char *, size_t); typedef __ssize_t cookie_write_function_t(void *, const char *, size_t);
typedef int cookie_seek_function_t(void *, off64_t *, int); typedef int cookie_seek_function_t(void *, off64_t *, int);
typedef int cookie_close_function_t(void *); typedef int cookie_close_function_t(void *);
typedef struct { typedef struct {
cookie_read_function_t *read; cookie_read_function_t *read;
cookie_write_function_t *write; cookie_write_function_t *write;
cookie_seek_function_t *seek; cookie_seek_function_t *seek;
cookie_close_function_t *close; cookie_close_function_t *close;
} cookie_io_functions_t; } cookie_io_functions_t;
FILE *fopencookie(void *, const char *, cookie_io_functions_t); FILE *fopencookie(void *, const char *, cookie_io_functions_t);
#endif
/* /*
* Portability hacks. See <sys/types.h>. * Portability hacks. See <sys/types.h>.
*/ */
#ifndef _FTRUNCATE_DECLARED #ifndef _FTRUNCATE_DECLARED
#define _FTRUNCATE_DECLARED #define _FTRUNCATE_DECLARED
int ftruncate(int, __off_t); int ftruncate(int, __off_t);
#endif #endif
▲ Show 20 Lines • Show All 97 Lines • Show Last 20 Lines