hwpmc_mod.c: conditional and loop style
ClosedPublic
Actions

Authored by mhorne on Jun 13 2023, 5:52 PM.

Details

Reviewers

jkoshy
gnn

Commits

rGd5ee4074c2c3: hwpmc_mod.c: conditional and loop style

Summary

Explicitly check the value in conditional statements, per style(9)
Add braces around more loops and conditionals, wherever it appears (to me) to aid legibility
Expand some assignments within if statements
Fix formatting around list-type FOREACH macros

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 52024
Build 48915: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 13 2023, 5:52 PM

Herald added a reviewer: gnn. · View Herald TranscriptJun 13 2023, 5:52 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Jun 13 2023, 5:52 PM

Harbormaster completed remote builds in B52024: Diff 123163.Jun 13 2023, 5:52 PM

jkoshy accepted this revision.Jun 14 2023, 9:53 AM

jkoshy added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
3037	You could save an indentation level by not having an 'else' clause.

This revision is now accepted and ready to land.Jun 14 2023, 9:53 AM

Closed by commit rGd5ee4074c2c3: hwpmc_mod.c: conditional and loop style (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked an inline comment as done.

mhorne added a commit: rGd5ee4074c2c3: hwpmc_mod.c: conditional and loop style.

mhorne mentioned this in D40289: hwpmc: style(9) pass of hwpmc_mod.c.Jun 14 2023, 4:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

332 lines

Diff 123163

View Options

hwpmc_mod.c: conditional and loop styleClosedPublicActions