Page MenuHomeFreeBSD
Differential D40287

developers-handbook: Fix broken links
ClosedPublic
Actions

Authored by macdonald.umoren_proton.me on May 26 2023, 6:13 PM.
Tags
None
Referenced Files
F167872399: D40287.diff
Tue, Aug 25, 3:58 AM
F167851112: D40287.id.diff
Tue, Aug 25, 12:19 AM
F167834659: D40287.diff
Mon, Aug 24, 9:14 PM
Unknown Object (File)
Sun, Aug 23, 1:05 PM
Unknown Object (File)
Sat, Aug 22, 3:48 PM
Unknown Object (File)
Sat, Aug 22, 3:18 PM
Unknown Object (File)
Sat, Aug 22, 12:52 PM
Unknown Object (File)
Sat, Aug 22, 9:30 AM
View All Files
Subscribers
fernape

Details

Reviewers
fernape
Group Reviewers
docs
Commits
R9:3b95ab69fde3: Developers handbook: Fix broken links in kernel build chapter
Summary

Fix links to Building and Installing a Custom Kernel
section of the handbook

Test Plan

Links in generated html are changed from https://docs.freebsd.org/en/books/handbook/#kernelconfig-building to https://docs.freebsd.org/en/books/handbook/kernelconfig/#kernelconfig-building

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51715
Build 48606: arc lint + arc unit

Event Timeline

macdonald.umoren_proton.me requested review of this revision.May 26 2023, 6:13 PM
macdonald.umoren_proton.me created this revision.
Harbormaster completed remote builds in B51715: Diff 122488.May 26 2023, 6:14 PM
macdonald.umoren_proton.me edited the test plan for this revision. (Show Details)May 26 2023, 6:18 PM
lwhsu edited reviewers, added: docs; removed: doceng.May 26 2023, 6:30 PM
fernape added a subscriber: fernape.May 28 2023, 5:32 PM

Change points to

https://docs.freebsd.org/en/books/handbook/#kernelconfig-building but I think the proper anchor is:
https://docs.freebsd.org/en/books/handbook/book/#kernelconfig-building

Otherwise we end up in the chapter-splitted version of the handbook when clicking on the link and we don't go to the kernel config specific section.

macdonald.umoren_proton.me added a comment.May 29 2023, 4:52 PM
In D40287#917802, @fernape wrote:

Change points to

https://docs.freebsd.org/en/books/handbook/#kernelconfig-building but I think the proper anchor is:
https://docs.freebsd.org/en/books/handbook/book/#kernelconfig-building

The changes point to https://docs.freebsd.org/en/books/handbook/kernelconfig/#kernelconfig-building

fernape added a comment.May 30 2023, 7:14 AM
In D40287#918020, @macdonald.umoren_proton.me wrote:
In D40287#917802, @fernape wrote:

Change points to

https://docs.freebsd.org/en/books/handbook/#kernelconfig-building but I think the proper anchor is:
https://docs.freebsd.org/en/books/handbook/book/#kernelconfig-building

The changes point to https://docs.freebsd.org/en/books/handbook/kernelconfig/#kernelconfig-building

I just rebuilt the doc again and I see you're right. Sorry for the noise!

fernape accepted this revision.May 30 2023, 7:14 AM

LGTM!

This revision is now accepted and ready to land.May 30 2023, 7:14 AM
macdonald.umoren_proton.me added a comment.May 30 2023, 4:35 PM

Thanks for the review. Please go ahead and commit

Closed by commit R9:3b95ab69fde3: Developers handbook: Fix broken links in kernel build chapter (authored by macdonald.umoren_proton.me, committed by carlavilla). · Explain WhyJul 14 2023, 8:41 AM
This revision was automatically updated to reflect the committed changes.
carlavilla added a commit: R9:3b95ab69fde3: Developers handbook: Fix broken links in kernel build chapter.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
developers-handbook/
kernelbuild/
4 lines
4 lines

Diff 122488

View Options

documentation/content/en/books/developers-handbook/kernelbuild/_index.adoc

Loading...
View Options

documentation/content/en/books/developers-handbook/kernelbuild/_index.po

Loading...