Page MenuHomeFreeBSD
Differential D40283

kinst: check for 'push %rbp' anywhere in the function
ClosedPublic
Actions

Authored by christos on May 26 2023, 1:44 PM.
Tags
None
Referenced Files
F125810498: D40283.id124854.diff
Tue, Aug 12, 6:26 AM
Unknown Object (File)
Sun, Jul 27, 11:55 PM
Unknown Object (File)
Sun, Jul 20, 2:16 AM
Unknown Object (File)
Sat, Jul 19, 6:53 PM
Unknown Object (File)
Sat, Jul 19, 9:55 AM
Unknown Object (File)
Jul 12 2025, 11:45 AM
Unknown Object (File)
Jun 27 2025, 1:29 AM
Unknown Object (File)
Jun 23 2025, 5:26 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
Commits
rGea89133dbc5f: kinst: check for 'push %rbp' anywhere in the function
Summary

Currently kinst checks if only the first instruction is 'push %rbp',
essentially excluding functions that do push RBP, but not in the first
instruction.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51708
Build 48599: arc lint + arc unit

Event Timeline

christos created this revision.May 26 2023, 1:44 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2023, 1:44 PM
christos requested review of this revision.May 26 2023, 1:44 PM
Harbormaster completed remote builds in B51708: Diff 122470.May 26 2023, 1:44 PM
christos added a parent revision: D39229: kinst: add kinst_excluded().May 26 2023, 1:44 PM
christos removed a parent revision: D39229: kinst: add kinst_excluded().May 26 2023, 2:53 PM
christos updated this revision to Diff 122608.May 30 2023, 2:07 PM

Check for 'pop %rbp' as well.

Harbormaster completed remote builds in B51773: Diff 122608.May 30 2023, 2:07 PM
markj added inline comments.Jul 4 2023, 4:06 PM
sys/cddl/dev/kinst/amd64/kinst_isa.c
515–516

The first sentence isn't really accurate anymore. I'd just replace the comment with something like, "refuse to instrument functions lacking the usual frame pointer manipulations since they might correspond to exception handlers."

christos updated this revision to Diff 124744.Jul 16 2023, 4:33 PM
christos marked an inline comment as done.

Address Mark's comment.

Harbormaster completed remote builds in B52668: Diff 124744.Jul 16 2023, 4:33 PM
markj accepted this revision.Jul 19 2023, 1:56 PM

Please note in the commit message that this behaviour matches that of FBT. That is, FBT will put an entry probe on any function that contains a push %rbp.

This revision is now accepted and ready to land.Jul 19 2023, 1:56 PM
Closed by commit rGea89133dbc5f: kinst: check for 'push %rbp' anywhere in the function (authored by christos). · Explain WhyJul 19 2023, 3:00 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGea89133dbc5f: kinst: check for 'push %rbp' anywhere in the function.

Revision Contents
Changeset List

PathSize
sys/
cddl/
dev/
kinst/
amd64/
17 lines

Diff 122470

View Options

sys/cddl/dev/kinst/amd64/kinst_isa.c

Loading...