ctags: Recognize attribute in function declarations.
ClosedPublic
Actions

Authored by des on May 25 2023, 2:28 PM.

Details

Reviewers

kevans

Group Reviewers

Klara

Commits

rG9f35eb8f96a5: ctags: Recognize __attribute__ in function declarations.

Summary

MFC after: 1 week
Obtained from: NetBSD
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51678
Build 48569: arc lint + arc unit

Event Timeline

des created this revision.May 25 2023, 2:28 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2023, 2:28 PM

des requested review of this revision.May 25 2023, 2:28 PM

Harbormaster completed remote builds in B51678: Diff 122412.May 25 2023, 2:28 PM

kevans added a subscriber: kevans.May 25 2023, 2:44 PM

kevans added inline comments.

usr.bin/ctags/C.c
266	Why `+ 1`? `sizeof attribute` should already account for the nul byte and the arithmetic below seems to acknowledge that

des marked an inline comment as done.May 25 2023, 4:31 PM

des added inline comments.

usr.bin/ctags/C.c
266	I know but that's how it is upstream. I'm probably going to refactor it soon anyway.

des marked an inline comment as done.May 25 2023, 4:31 PM

Fair enough

This revision is now accepted and ready to land.May 25 2023, 4:36 PM

Closed by commit rG9f35eb8f96a5: ctags: Recognize __attribute__ in function declarations. (authored by des). · Explain WhyMay 25 2023, 6:17 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG9f35eb8f96a5: ctags: Recognize __attribute__ in function declarations..

des mentioned this in rG06520254ed83: ctags: Support writing to stdout instead of a file..Jun 14 2023, 1:26 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

ctags/

C.c

33 lines

Diff 122412

View Options

ctags: Recognize __attribute__ in function declarations.ClosedPublicActions