Differential D40225

motd: Adapt with recent changes.
ClosedPublic
Actions

Authored by delphij on May 23 2023, 4:36 AM.

Tags

None

Referenced Files

	F129795060: D40225.id122267.diff
	Wed, Sep 24, 1:06 AM

	F129742443: D40225.diff
	Tue, Sep 23, 3:17 PM

	Unknown Object (File)
	Mon, Sep 22, 6:02 PM

	Unknown Object (File)
	Wed, Sep 17, 5:47 PM

	Unknown Object (File)
	Wed, Sep 17, 4:01 AM

	Unknown Object (File)
	Thu, Sep 11, 8:29 PM

	Unknown Object (File)
	Thu, Sep 11, 8:05 AM

	Unknown Object (File)
	Sat, Sep 6, 3:31 AM

Subscribers

jamie_catflap.org

Details

Reviewers

imp
emaste

Commits

rG634a770a5e16: /etc/rc.d/motd: Update to accommodate changes in uname(1) and newvers.sh

Summary

/etc/rc.d/motd: Update to accommodate changes in uname(1) and newvers.sh

The recent changes to the uname(1) command removed trailing spaces for
better POSIX conformance, but it broke the regular expression used by
the motd script which expected it. This commit addresses this by removing
the requirement, as it is no longer present.

Additionally, a recent change in newvers.sh introduced a new format for
uname -v, which omited the build number and build dates to improve
reproducible build support. This commit adds support for this new format.

Reported-by: Jamie Landeg-Jones <jamie@catflap.org>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij requested review of this revision.May 23 2023, 4:36 AM

delphij created this revision.

Harbormaster completed remote builds in B51627: Diff 122267.May 23 2023, 4:36 AM

Nice.. there was a freebsd-version phabricator or pull request that can use these REs instead of the badly broken ones there now.

This revision is now accepted and ready to land.May 23 2023, 5:00 AM

Closed by commit rG634a770a5e16: /etc/rc.d/motd: Update to accommodate changes in uname(1) and newvers.sh (authored by delphij). · Explain WhyMay 23 2023, 5:06 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rG634a770a5e16: /etc/rc.d/motd: Update to accommodate changes in uname(1) and newvers.sh.

jamie_catflap.org added a subscriber: jamie_catflap.org.May 23 2023, 10:47 AM

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.d/

3 lines

Diff 122268

libexec/rc/rc.d/motd

Loading...