Differential D40171

net/realtek-re-kmod: Use C89 function declarations.
ClosedPublic
Actions

Authored by jhb on May 20 2023, 12:52 AM.

Tags

None

Referenced Files

	F160680915: D40171.diff
	Fri, Jun 26, 5:46 PM

	Unknown Object (File)
	Sun, Jun 21, 9:57 PM

	Unknown Object (File)
	Sat, Jun 20, 6:50 PM

	Unknown Object (File)
	Fri, Jun 19, 4:53 PM

	Unknown Object (File)
	Thu, Jun 18, 4:12 PM

	Unknown Object (File)
	Thu, Jun 18, 11:08 AM

	Unknown Object (File)
	Sat, Jun 13, 7:41 AM

	Unknown Object (File)
	Thu, Jun 11, 8:46 PM

Subscribers

Details

Reviewers

Commits

R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51568
Build 48459: arc lint + arc unit

Event Timeline

jhb created this revision.May 20 2023, 12:52 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 20 2023, 12:52 AM

jhb requested review of this revision.May 20 2023, 12:52 AM

Harbormaster completed remote builds in B51568: Diff 122143.May 20 2023, 12:52 AM

Just to know, is this required by a compiler update?

In D40171#915122, @ale wrote:

Just to know, is this required by a compiler update?

I'm planning on turning on a warning in clang 15 that is currently muted for the kernel that this trips up.

Actually, my bad, I already enabled the warning for this in main. I have another warning I'm enabling and the exp-run for the second warning found this breakage from the first (I guess the module was broken for some other reason at the time I ran the earlier exp-run).

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2023, 6:35 AM

Closed by commit R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations. (authored by ale). · Explain Why

This revision was automatically updated to reflect the committed changes.

ale added a commit: R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations..

Revision Contents
Changeset List

Path

Size

net/

realtek-re-kmod/

files/

196 lines

Diff 122143

net/realtek-re-kmod/files/patch-if__re.c

Loading...