Differential D40171

net/realtek-re-kmod: Use C89 function declarations.
ClosedPublic
Actions

Authored by jhb on May 20 2023, 12:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 19, 10:04 AM

	Unknown Object (File)
	Tue, Sep 19, 10:02 AM

	Unknown Object (File)
	Tue, Sep 19, 10:00 AM

	Unknown Object (File)
	Mon, Sep 4, 12:39 AM

	Unknown Object (File)
	Jul 8 2023, 3:08 PM

	Unknown Object (File)
	Jul 8 2023, 3:07 PM

	Unknown Object (File)
	Jul 8 2023, 3:05 PM

	Unknown Object (File)
	Jul 4 2023, 8:15 AM

View All 23 Files

Subscribers

Details

Reviewers

Commits

R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.May 20 2023, 12:52 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 20 2023, 12:52 AM

jhb requested review of this revision.May 20 2023, 12:52 AM

Harbormaster completed remote builds in B51568: Diff 122143.May 20 2023, 12:52 AM

Just to know, is this required by a compiler update?

In D40171#915122, @ale wrote:

Just to know, is this required by a compiler update?

I'm planning on turning on a warning in clang 15 that is currently muted for the kernel that this trips up.

Actually, my bad, I already enabled the warning for this in main. I have another warning I'm enabling and the exp-run for the second warning found this breakage from the first (I guess the module was broken for some other reason at the time I ran the earlier exp-run).

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2023, 6:35 AM

Closed by commit R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations. (authored by ale). · Explain Why

This revision was automatically updated to reflect the committed changes.

ale added a commit: R11:22eacba09ade: net/realtek-re-kmod: Use C89 function declarations..

Revision Contents
Changeset List

Path

Size

net/

realtek-re-kmod/

2 lines

6 lines

Diff 122269

net/realtek-re-kmod/Makefile

Loading...

net/realtek-re-kmod/distinfo

Loading...