Page MenuHomeFreeBSD
Differential D4807

Add alternate ptrace()-based thread target.
AbandonedPublic
Actions

Authored by jhb on Jan 6 2016, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 18 2024, 5:39 AM
Unknown Object (File)
Mar 13 2024, 7:51 AM
Unknown Object (File)
Mar 7 2024, 12:44 AM
Unknown Object (File)
Mar 7 2024, 12:44 AM
Unknown Object (File)
Mar 7 2024, 12:44 AM
Unknown Object (File)
Mar 7 2024, 12:43 AM
Unknown Object (File)
Mar 7 2024, 12:43 AM
Unknown Object (File)
Mar 7 2024, 12:43 AM
View All 64 Files
Subscribers
emaste
luca.pizzamiglio_gmail.com

Details

Reviewers
None
Summary

Split the THREADS option into a radio option to support choosing between
multiple thread targets. Add a new thread target for a ptrace()-based
thread target.

Test Plan
  • Able to build the port ok with new thread target and KGDB enabled.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2045
Build 2053: arc lint + arc unit

Event Timeline

jhb updated this revision to Diff 11974.Jan 6 2016, 10:29 PM
jhb retitled this revision from to Add alternate ptrace()-based thread target..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
Herald added a subscriber: emaste. · View Herald TranscriptJan 6 2016, 10:29 PM
luca.pizzamiglio_gmail.com added a subscriber: luca.pizzamiglio_gmail.com.Jan 11 2016, 1:49 PM

Small fix suggested in the Makefile

devel/gdb/Makefile
91

The option name is wrong. It should be;
.if {PORT_OPTIONS:MPTRACE_THREAD}

jhb updated this revision to Diff 12121.Jan 11 2016, 5:16 PM

Fix port option check.

jhb marked an inline comment as done.Jan 11 2016, 5:17 PM
jhb updated this revision to Diff 12133.Jan 11 2016, 11:42 PM

Update patch so that it applies.

jhb updated this revision to Diff 12137.Jan 12 2016, 1:38 AM

Fix a bug with fbsd_thread_name().

jhb updated this revision to Diff 12143.Jan 12 2016, 5:33 AM

Dump the signalled thread first when generating a core dump.

jhb added a comment.Jan 12 2016, 5:42 AM

I'm not sure why this keeps thinking the new file is empty. arc is a bit busted it seems.

I've dropped the binutils bits of the patch. The only effect there is that thread names are not found in core dumps, though I'm testing a hack (that would not go upstream but would be a patch to the port in the future) to recognize the alternate name (".tname") that the in-tree binutils uses for the NT_THRMISC notes.

jhb updated this revision to Diff 12212.Jan 12 2016, 6:01 PM

Put back the libbfd bits I trimmed earlier. This restores thread name support
in core dumps. Only the binutils/readelf.c changes need to be left out of the
original patch.

jhb abandoned this revision.Mar 18 2016, 5:48 PM

7.11 has been merged into ports which includes these changes.

Revision Contents
Changeset List

PathSize
devel/
gdb/
17 lines
files/

Diff 12137

View Options

devel/gdb/Makefile

Loading...
View Options

devel/gdb/files/extrapatch-threads-ptrace

Loading...