Page MenuHomeFreeBSD
Differential D39791

stand: Testing program for smbios
ClosedPublic
Actions

Authored by imp on Apr 25 2023, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 8 2025, 3:11 AM
Unknown Object (File)
Feb 11 2025, 6:39 AM
Unknown Object (File)
Feb 10 2025, 11:43 PM
Unknown Object (File)
Feb 1 2025, 5:20 PM
Unknown Object (File)
Feb 1 2025, 2:15 PM
Unknown Object (File)
Jan 23 2025, 6:25 PM
Unknown Object (File)
Jan 20 2025, 12:27 PM
Unknown Object (File)
Jan 2 2025, 2:54 AM
View All 50 Files
Subscribers
dab

Details

Reviewers
kevans
Commits
rGcf6044857e2b: stand: Testing program for smbios
Summary

Write a quick and dirty testing program to dump physical memory to help
test and debug the smbios.c code in new environments.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51166
Build 48057: arc lint + arc unit

Event Timeline

imp created this revision.Apr 25 2023, 4:25 AM
Herald added a subscriber: dab. · View Herald TranscriptApr 25 2023, 4:25 AM
imp requested review of this revision.Apr 25 2023, 4:25 AM
Harbormaster completed remote builds in B51166: Diff 120976.Apr 25 2023, 4:25 AM
imp added a parent revision: D39790: kboot: Add HOST_MAP_FAILED define.Apr 25 2023, 4:25 AM
imp added a reviewer: kevans.Apr 25 2023, 4:27 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 1 2023, 9:29 PM
Closed by commit rGcf6044857e2b: stand: Testing program for smbios (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGcf6044857e2b: stand: Testing program for smbios.

Revision Contents
Changeset List

PathSize
tools/
boot/
smbios/
11 lines
96 lines
18 lines

Diff 120976

View Options

tools/boot/smbios/Makefile

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

tools/boot/smbios/main.c

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines
View Options

tools/boot/smbios/stand.h

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines union {
} vop_args; } vop_args;
} args; } args;
}; };
static int vn_io_fault1(struct vnode *vp, struct uio *uio, static int vn_io_fault1(struct vnode *vp, struct uio *uio,
struct vn_io_fault_args *args, struct thread *td); struct vn_io_fault_args *args, struct thread *td);
int int
vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp) vn_open(struct nameidata *ndp, int *flagp, int cmode, struct file *fp)
kibUnsubmitted
Not Done
Inline Actions

Why do you need this?

For rw it was needed due to the vn_io_fault() structure, for vn_deallocate() it is pointless complication.

kib: Why do you need this? For rw it was needed due to the vn_io_fault() structure, for…
{ {
struct thread *td = ndp->ni_cnd.cn_thread; struct thread *td = ndp->ni_cnd.cn_thread;
return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp)); return (vn_open_cred(ndp, flagp, cmode, 0, td->td_ucred, fp));
} }
static uint64_t static uint64_t
open2nameif(int fmode, u_int vn_open_flags) open2nameif(int fmode, u_int vn_open_flags)
▲ Show 20 Lines • Show All 3,260 Lines • ▼ Show 20 Lines#endif
return (error); return (error);
} }
static int static int
vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate_impl(struct vnode *vp, off_t *offset, off_t *length, int flags,
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
struct ucred *cred;
struct mount *mp; struct mount *mp;
void *rl_cookie; void *rl_cookie;
off_t off, len; off_t off, len;
int error; int error;
#ifdef AUDIT #ifdef AUDIT
bool audited_vnode1 = false; bool audited_vnode1 = false;
#endif #endif
Show All 27 Lines#ifdef AUDIT
} }
#endif #endif
#ifdef MAC #ifdef MAC
if ((ioflag & IO_NOMACCHECK) == 0) if ((ioflag & IO_NOMACCHECK) == 0)
error = mac_vnode_check_write(active_cred, file_cred, error = mac_vnode_check_write(active_cred, file_cred,
vp); vp);
#endif #endif
if (error == 0) if (error == 0) {
if (file_cred != NULL)
cred = file_cred;
else
cred = active_cred;
error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag, error = VOP_DEALLOCATE(vp, &off, &len, flags, ioflag,
active_cred); cred);
}
if ((ioflag & IO_NODELOCKED) == 0) { if ((ioflag & IO_NODELOCKED) == 0) {
VOP_UNLOCK(vp); VOP_UNLOCK(vp);
if (mp != NULL) { if (mp != NULL) {
vn_finished_write(mp); vn_finished_write(mp);
mp = NULL; mp = NULL;
} }
} }
if (error == 0 && len != 0) if (error == 0 && len != 0)
maybe_yield(); maybe_yield();
} }
out: out:
if (rl_cookie != NULL) if (rl_cookie != NULL)
vn_rangelock_unlock(vp, rl_cookie); vn_rangelock_unlock(vp, rl_cookie);
*offset = off; *offset = off;
*length = len; *length = len;
return (error); return (error);
} }
int int
vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags, vn_deallocate(struct vnode *vp, off_t *offset, off_t *length, int flags,
kibUnsubmitted
Not Done
Inline Actions

When I talked about commenting the use, I mean that it should explain that function is supposed to be used in the situations where the op is not triggered by a user request. In other words, currthread->td_ucred == active_cred is generally not the right credentials to account the operation to.

Your line above just repeats the code.

kib: When I talked about commenting the use, I mean that it should explain that function is supposed…
int ioflag, struct ucred *active_cred, struct ucred *file_cred) int ioflag, struct ucred *active_cred, struct ucred *file_cred)
{ {
if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset || if (*offset < 0 || *length <= 0 || *length > OFF_MAX - *offset ||
flags != 0) flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
return (vn_deallocate_impl(vp, offset, length, flags, ioflag, return (vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, file_cred)); active_cred, file_cred));
} }
kibUnsubmitted
Done
Inline Actions

cred = file_cred != NOCRED ? file_cred : active_cred;

kib: `cred = file_cred != NOCRED ? file_cred : active_cred;`
static int static int
vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags, vn_fspacectl(struct file *fp, int cmd, off_t *offset, off_t *length, int flags,
struct ucred *active_cred, struct thread *td) struct ucred *active_cred, struct thread *td)
{ {
int error; int error;
struct vnode *vp; struct vnode *vp;
int ioflag; int ioflag;
vp = fp->f_vnode; vp = fp->f_vnode;
if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 || if (cmd != SPACECTL_DEALLOC || *offset < 0 || *length <= 0 ||
*length > OFF_MAX - *offset || flags != 0) *length > OFF_MAX - *offset || flags != 0)
return (EINVAL); return (EINVAL);
if (vp->v_type != VREG) if (vp->v_type != VREG)
return (ENODEV); return (ENODEV);
ioflag = get_write_ioflag(fp); ioflag = get_write_ioflag(fp);
switch (cmd) { switch (cmd) {
case SPACECTL_DEALLOC: case SPACECTL_DEALLOC:
error = vn_deallocate_impl(vp, offset, length, flags, ioflag, error = vn_deallocate_impl(vp, offset, length, flags, ioflag,
active_cred, fp->f_cred); active_cred, fp->f_cred);
kibUnsubmitted
Not Done
Inline Actions

why passing fp->f_cred there at all?
from_fops is ugly and arguably not needed.
vn_deallocate() needs explanation about active_cre/file_cred in a comment, nobody would read man page for this (or in both)

kib: why passing fp->f_cred there at all? from_fops is ugly and arguably not needed. vn_deallocate()…
khngAuthorUnsubmitted
Not Done
Inline Actions

The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the policy modules in base so far are not taking f_cred into consideration at all).

khng: The fp->f_cred was there to for mac_vnode_check_write's policy checking (although all the…
khngAuthorUnsubmitted
Done
Inline Actions

A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base policy module, it is possibly used by outside world to implement capability semantic.

khng: A mental note to myself: Though mac_vnode_check_write()'s file_cred is not inspected by in base…
break; break;
default: default:
panic("vn_fspacectl: unknown cmd %d", cmd); panic("vn_fspacectl: unknown cmd %d", cmd);
} }
return (error); return (error);
} }
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines