Page MenuHomeFreeBSD
Differential D39646

linux(4): Export the AT_RANDOM depending on the process osreldata
ClosedPublic
Actions

Authored by dchagin on Apr 18 2023, 10:17 AM.
Tags
Referenced Files
F156955400: D39646.id120551.diff
Sun, May 17, 3:19 PM
Unknown Object (File)
Sun, May 17, 3:09 AM
Unknown Object (File)
Sun, May 17, 1:08 AM
Unknown Object (File)
Sun, May 17, 1:03 AM
Unknown Object (File)
Sat, May 16, 11:32 PM
Unknown Object (File)
Sat, May 16, 11:23 PM
Unknown Object (File)
Sat, May 16, 4:22 PM
Unknown Object (File)
Thu, May 14, 6:52 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
Linux Emulation
Commits
rGde67d174a10c: linux(4): Export the AT_RANDOM depending on the process osreldata
rG40c36c4674eb: linux(4): Export the AT_RANDOM depending on the process osreldata
Summary

AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50993
Build 47884: arc lint + arc unit

Event Timeline

dchagin created this revision.Apr 18 2023, 10:17 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 18 2023, 10:17 AM
dchagin requested review of this revision.Apr 18 2023, 10:17 AM
Harbormaster completed remote builds in B50993: Diff 120551.Apr 18 2023, 10:17 AM
dchagin added a reviewer: Linux Emulation.Apr 18 2023, 10:22 AM
dchagin added a project: Linux Emulation.
emaste added a subscriber: emaste.Apr 18 2023, 12:28 PM

My quick google suggests Linux AT_CANARY is defined as pointing to 16 random bytes.
Should we add either a runtime test or assertion that imgp->canarylen >= 16?

dchagin added a comment.Apr 18 2023, 1:03 PM
In D39646#902353, @emaste wrote:

My quick google suggests Linux AT_CANARY is defined as pointing to 16 random bytes.
Should we add either a runtime test or assertion that imgp->canarylen >= 16?

https://cgit.freebsd.org/src/tree/sys/compat/linux/linux_elf.c#n332

emaste accepted this revision.Apr 18 2023, 1:11 PM
This revision is now accepted and ready to land.Apr 18 2023, 1:11 PM
Closed by commit rG40c36c4674eb: linux(4): Export the AT_RANDOM depending on the process osreldata (authored by dchagin). · Explain WhyApr 22 2023, 7:19 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG40c36c4674eb: linux(4): Export the AT_RANDOM depending on the process osreldata.
dchagin added a commit: rGde67d174a10c: linux(4): Export the AT_RANDOM depending on the process osreldata.Jun 29 2023, 8:20 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
3 lines
1 line

Diff 120551

View Options

sys/compat/linux/linux_elf.c

Loading...
View Options

sys/compat/linux/linux_mib.h

Loading...