Page MenuHomeFreeBSD
Differential D39525

less: Silence -Wdeprecated-non-prototype warnings.
ClosedPublic
Actions

Authored by jhb on Apr 12 2023, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 4, 6:25 PM
Unknown Object (File)
Wed, Sep 2, 4:50 PM
Unknown Object (File)
Sun, Aug 30, 5:00 AM
Unknown Object (File)
Aug 12 2026, 7:41 PM
Unknown Object (File)
Aug 11 2026, 3:00 AM
Unknown Object (File)
Aug 10 2026, 11:11 AM
Unknown Object (File)
Aug 9 2026, 5:57 PM
Unknown Object (File)
Aug 9 2026, 4:38 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG1bd44215d048: less: Silence -Wdeprecated-non-prototype warnings.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50856
Build 47747: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 12 2023, 3:33 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 3:33 PM
jhb requested review of this revision.Apr 12 2023, 3:33 PM
Harbormaster completed remote builds in B50856: Diff 120204.Apr 12 2023, 3:33 PM
jhb added a parent revision: D39524: ee: Silence -Wdeprecated-non-prototype warnings..Apr 12 2023, 3:33 PM
jhb added a child revision: D39526: locate: Use C89 function definitions..
jhb added inline comments.Apr 12 2023, 7:00 PM
usr.bin/less/Makefile
22

This didn't work since it was before bsd.prog.mk. (And also, this is why this change can't be in Makefile.common instead)

emaste added a comment.Apr 12 2023, 7:06 PM

I suspect we can get this addressed upstream with an issue or pull request at https://github.com/gwsw/less

emaste accepted this revision.Apr 13 2023, 2:04 PM
This revision is now accepted and ready to land.Apr 13 2023, 2:04 PM
jhb added a comment.Apr 18 2023, 6:26 PM

I opened an issue at https://github.com/gwsw/less/issues/361

Closed by commit rG1bd44215d048: less: Silence -Wdeprecated-non-prototype warnings. (authored by jhb). · Explain WhyApr 18 2023, 6:32 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG1bd44215d048: less: Silence -Wdeprecated-non-prototype warnings..

Revision Contents
Changeset List

PathSize
usr.bin/
less/
4 lines
lessecho/
2 lines
lesskey/
2 lines

Diff 120204

View Options

usr.bin/less/Makefile

Loading...
View Options

usr.bin/lessecho/Makefile

Loading...
View Options

usr.bin/lesskey/Makefile

Loading...