Differential D39519

smbfs: Use C89 function definition for cf_getopt.
ClosedPublic
Actions

Authored by jhb on Apr 12 2023, 3:32 PM.

Details

Reviewers

emaste

Commits

rGf6fd5356b3fc: smbfs: Use C89 function definition for cf_getopt.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50850
Build 47741: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 12 2023, 3:32 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 12 2023, 3:32 PM

jhb requested review of this revision.Apr 12 2023, 3:32 PM

jhb added a parent revision: D39518: sendmail: Silence -Wdeprecated-non-prototype warnings..

Harbormaster completed remote builds in B50850: Diff 120198.Apr 12 2023, 3:32 PM

jhb added a child revision: D39520: bootpd: Use C89 function definitions..Apr 12 2023, 3:32 PM

are there smbfs copies elsewhere (other operating systems) that should also get this change?

This revision is now accepted and ready to land.Apr 12 2023, 3:51 PM

In D39519#899892, @emaste wrote:

are there smbfs copies elsewhere (other operating systems) that should also get this change?

I have no idea. I assumed that this doesn't have a live upstream so it was ok to fix it directly instead.

Closed by commit rGf6fd5356b3fc: smbfs: Use C89 function definition for cf_getopt. (authored by jhb). · Explain WhyApr 18 2023, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf6fd5356b3fc: smbfs: Use C89 function definition for cf_getopt..

Revision Contents
Changeset List

Path

Size

contrib/

smbfs/

lib/

smb/

cfopt.c

5 lines

Diff 120198

View Options

contrib/smbfs/lib/smb/cfopt.c

smbfs: Use C89 function definition for cf_getopt.ClosedPublicActions