Page MenuHomeFreeBSD
Differential D39351

ipmi: Remove some dead code for unsupported BMCs.
ClosedPublic
Actions

Authored by jhb on Mar 30 2023, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 9:44 PM
Unknown Object (File)
Tue, Apr 1, 8:44 PM
Unknown Object (File)
Jan 12 2025, 8:08 PM
Unknown Object (File)
Jan 9 2025, 12:16 PM
Unknown Object (File)
Jan 8 2025, 9:51 PM
Unknown Object (File)
Dec 31 2024, 10:09 PM
Unknown Object (File)
Dec 10 2024, 6:47 AM
Unknown Object (File)
Nov 21 2024, 10:34 AM
View All 96 Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rG677e70e0c472: ipmi: Remove some dead code for unsupported BMCs.
Summary

Reported by: GCC

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
6 lines

Diff 120097

View Options

sys/dev/ipmi/ipmi_acpi.c

  • This file was added.
#include <atf-c.h>
#include <alias.h>
#include <stdio.h>
#include <stdlib.h>
#include "util.h"
ATF_TC_WITHOUT_HEAD(1_portforward);
ATF_TC_BODY(1_portforward, dummy)
{
struct libalias *la = LibAliasInit(NULL);
struct alias_link *pf1, *pf2, *pf3, *pf4;
struct ip *p;
struct udphdr *u;
ATF_REQUIRE(la != NULL);
LibAliasSetAddress(la, masq);
LibAliasSetMode(la, PKT_ALIAS_RESET_ON_ADDR_CHANGE, ~0);
LibAliasSetMode(la, PKT_ALIAS_DENY_INCOMING, PKT_ALIAS_DENY_INCOMING);
/*
* Fully specified
*/
pf1 = LibAliasRedirectPort(la, prv1, ntohs(0x1234), ext, ntohs(0x5678), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf1 != NULL);
p = ip_packet(0, 64);
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
/* try again */
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
/* different source */
UDP_UNNAT_FAIL(p, u, pub, 0x5678, masq, 0xabcd);
UDP_UNNAT_FAIL(p, u, ext, 0xdead, masq, 0xabcd);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
/* delete and try again */
LibAliasRedirectDelete(la, pf1);
UDP_UNNAT_FAIL(p, u, ext, 0x5678, masq, 0xabcd);
/*
* Any external port
*/
pf2 = LibAliasRedirectPort(la, prv2, ntohs(0x1234), ext, ntohs(0), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf2 != NULL);
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, prv2);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* try again */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, prv2);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* different source */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_FAIL(p, pub, masq);
u = set_udp(p, 0xdead, 0xabcd);
UNNAT_CHECK(p, ext, masq, prv2);
ATF_CHECK(u->uh_sport == ntohs(0xdead));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
LibAliasRedirectDelete(la, pf2);
/* try again, but not the existing flow */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_FAIL(p, ext, masq);
/*
* Any external host
*/
pf3 = LibAliasRedirectPort(la, prv3, ntohs(0x1234), ANY_ADDR, ntohs(0x5678), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf3 != NULL);
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, prv3);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* try again */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, prv3);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* different source */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, pub, masq, prv3);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
u = set_udp(p, 0xdead, 0xabcd);
UNNAT_FAIL(p, ext, masq);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
LibAliasRedirectDelete(la, pf3);
/* try again, but not the existing flow */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_FAIL(p, ext, masq);
/*
* Any external host, any port
*/
pf4 = LibAliasRedirectPort(la, cgn, ntohs(0x1234), ANY_ADDR, ntohs(0), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf4 != NULL);
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, cgn);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* try again */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, ext, masq, cgn);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* different source */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_CHECK(p, pub, masq, cgn);
ATF_CHECK(u->uh_sport == ntohs(0x5678));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
u = set_udp(p, 0xdead, 0xabcd);
UNNAT_CHECK(p, ext, masq, cgn);
ATF_CHECK(u->uh_sport == ntohs(0xdead));
ATF_CHECK(u->uh_dport == ntohs(0x1234));
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
LibAliasRedirectDelete(la, pf4);
/* try again, but not the existing flow */
u = set_udp(p, 0x5678, 0xabcd);
UNNAT_FAIL(p, ext, masq);
free(p);
LibAliasUninit(la);
}
ATF_TC_WITHOUT_HEAD(2_portoverlap);
ATF_TC_BODY(2_portoverlap, dummy)
{
struct libalias *la = LibAliasInit(NULL);
struct alias_link *pf1, *pf2, *pf3, *pf4;
struct ip *p;
struct udphdr *u;
ATF_REQUIRE(la != NULL);
LibAliasSetAddress(la, masq);
LibAliasSetMode(la, PKT_ALIAS_RESET_ON_ADDR_CHANGE, ~0);
LibAliasSetMode(la, PKT_ALIAS_DENY_INCOMING, PKT_ALIAS_DENY_INCOMING);
/*
* Fully specified
*/
pf1 = LibAliasRedirectPort(la, prv2, ntohs(0x1234), ext, ntohs(0x5678), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf1 != NULL);
p = ip_packet(0, 64);
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv2, 0x1234);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
/*
* Fully specified (override)
*/
pf1 = LibAliasRedirectPort(la, prv1, ntohs(0x1234), ext, ntohs(0x5678), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf1 != NULL);
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
/*
* Any external port
*/
pf2 = LibAliasRedirectPort(la, prv2, ntohs(0x1234), ext, ntohs(0), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf2 != NULL);
UDP_UNNAT_CHECK(p, u, ext, 0x5679, masq, 0xabcd, prv2, 0x1234);
/* more specific rule wins */
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
/*
* Any external host
*/
pf3 = LibAliasRedirectPort(la, prv3, ntohs(0x1234), ANY_ADDR, ntohs(0x5678), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf3 != NULL);
UDP_UNNAT_CHECK(p, u, pub, 0x5678, masq, 0xabcd, prv3, 0x1234);
/* more specific rule wins */
UDP_UNNAT_CHECK(p, u, ext, 0x5679, masq, 0xabcd, prv2, 0x1234);
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
/* clear table by keeping the address */
LibAliasSetAddress(la, ext);
LibAliasSetAddress(la, masq);
/*
* Any external host, any port
*/
pf4 = LibAliasRedirectPort(la, cgn, ntohs(0x1234), ANY_ADDR, ntohs(0), masq, ntohs(0xabcd), IPPROTO_UDP);
ATF_REQUIRE(pf4 != NULL);
UDP_UNNAT_CHECK(p, u, prv1, 0x5679, masq, 0xabcd, cgn, 0x1234);
/* more specific rule wins */
UDP_UNNAT_CHECK(p, u, pub, 0x5678, masq, 0xabcd, prv3, 0x1234);
UDP_UNNAT_CHECK(p, u, ext, 0x5679, masq, 0xabcd, prv2, 0x1234);
UDP_UNNAT_CHECK(p, u, ext, 0x5678, masq, 0xabcd, prv1, 0x1234);
free(p);
LibAliasUninit(la);
}
ATF_TP_ADD_TCS(natin)
{
/* Use "dd if=/dev/random bs=2 count=1 | od -x" to reproduce */
srand(0xe859);
ATF_TP_ADD_TC(natin, 1_portforward);
ATF_TP_ADD_TC(natin, 2_portoverlap);
return atf_no_error();
}