Paths

Table of Contentst

Differential D39350

fuse: Remove set but unused cr_gid variable.
ClosedPublic
Actions

Authored by jhb on Mar 30 2023, 11:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 14, 11:20 AM

	Unknown Object (File)
	Wed, Aug 12, 3:05 PM

	Unknown Object (File)
	Mon, Aug 10, 4:19 AM

	Unknown Object (File)
	Sun, Aug 9, 6:29 PM

	Unknown Object (File)
	Sun, Aug 9, 6:27 PM

	Unknown Object (File)
	Sun, Aug 9, 6:27 PM

	Unknown Object (File)
	Sat, Aug 8, 3:15 AM

	Unknown Object (File)
	Sat, Aug 8, 1:03 AM

Subscribers

Details

Reviewers

Commits

rGcb750f7f5afb: fuse: Remove set but unused cr_gid variable.

Summary

Reported by: GCC

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50687
Build 47578: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 30 2023, 11:33 PM

Herald added subscribers: asomers, imp. · View Herald TranscriptMar 30 2023, 11:33 PM

jhb requested review of this revision.Mar 30 2023, 11:33 PM

jhb added a parent revision: D39349: linuxkpi: Appease -Wunused-but-set-variable warnings from GCC..

Harbormaster completed remote builds in B50687: Diff 119686.Mar 30 2023, 11:33 PM

jhb added a child revision: D39351: ipmi: Remove some dead code for unsupported BMCs..Mar 30 2023, 11:33 PM

asomers accepted this revision.Mar 31 2023, 12:42 AM

This revision is now accepted and ready to land.Mar 31 2023, 12:42 AM

jhb added inline comments.Mar 31 2023, 5:04 PM

sys/fs/fuse/fuse_vnops.c
2221	Btw, cr_gid is #define'd to `cr_groups[0]` in <sys/ucred.h> so I'm not really sure how this compiling without other warnings as it was expanding to things like `gid_t cr_groups[0];` and then in the assignments below `cr_groups[0] = cred->cr_groups[0];`. In theory -Warray-bounds should have caught that but didn't.

Closed by commit rGcb750f7f5afb: fuse: Remove set but unused cr_gid variable. (authored by jhb). · Explain WhyMar 31 2023, 5:59 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGcb750f7f5afb: fuse: Remove set but unused cr_gid variable..

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

5 lines

Diff 119686

sys/fs/fuse/fuse_vnops.c

Loading...