Globally unbundle zstd, similar to gettext, libgit2, libssh2, onigurama, OpenSSL.
Details
Details
- Reviewers
- None
- Group Reviewers
rust - Commits
- R11:046448bdb1f4: Mk/Uses/cargo.mk: unbundle archivers/zstd
28/28 consumers built fine in poudriere.
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Switch to BUILD_DEPENDS and drop PORTREVISION bump where libzstd.so is unused. Affects:
- sysutils/fselect
- textproc/meilisearch
- www/miniserve (onigurama is also unused but fixing it is outside of scope)
- www/wasm-pack
Comment Actions
Thanks for the diff and the heads-up regarding games/anki. I tried the latest version of this diff in conjunction with BUILD_DEPENDS+=zstd>0:archivers/zstd for games/anki and I had no issues with building it on 13.1-RELEASE amd64. Maybe it was an intermittent error?
Comment Actions
@kai, try building games/anki without BUILD_DEPENDS+=zstd>0:archivers/zstd (like the patch here intends). Not every zstd-sys consumer needs archivers/zstd.
Comment Actions
Ah, ok, I assumed that games/anki was omitted from this diff because it had generated the errors listed in "Test Plan".
However, even if BUILD_DEPENDS+=zstd>0:archivers/zstd is omitted, games/anki can be built without any problems (on 13.1-RELEASE amd64).
As far as I know, the Bazel build system is sometimes flaky and upstream has switched to another build system (homebrew rust build system in conjunction with Ninja) since release 2.1.55. (However, this is still pretty much a work in progress and will take some time to update games/anki to a newer release.)