Paths

Table of Contentst

Differential D38407

arpa: garbage collect ns_newmsg/ns_rdata decls
ClosedPublic
Actions

Authored by val_packett.cool on Feb 6 2023, 7:13 PM.

Details

Reviewers

emaste

Group Reviewers

Contributor Reviews (src)

Commits

rGf9c7fb7caed0: arpa: garbage collect ns_newmsg/ns_rdata decls

Summary

These were brought in by the libbind import in rG046c3635cd / rGe45764721a, but these functions were never actually implemented anywhere, only header declarations and symbol map entries were imported.

Reported by: ld.lld 16 being --no-undefined-version by default
Sponsored by: https://www.patreon.com/valpackett

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Feb 6 2023, 7:13 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2023, 7:13 PM

val_packett.cool requested review of this revision.Feb 6 2023, 7:13 PM

Harbormaster completed remote builds in B49573: Diff 116628.Feb 6 2023, 7:13 PM

val_packett.cool edited the summary of this revision. (Show Details)Feb 6 2023, 7:14 PM

val_packett.cool added reviewers: Contributor Reviews (src), emaste.

val_packett.cool added inline comments.

include/arpa/nameser.h
558	or should they be `#if 0`'d like this?..

emaste accepted this revision.Mar 21 2023, 4:22 PM

This revision is now accepted and ready to land.Mar 21 2023, 4:22 PM

Closed by commit rGf9c7fb7caed0: arpa: garbage collect ns_newmsg/ns_rdata decls (authored by val_packett.cool, committed by emaste). · Explain WhyMar 22 2023, 7:00 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGf9c7fb7caed0: arpa: garbage collect ns_newmsg/ns_rdata decls.

Revision Contents
Changeset List

Path

Size

include/

arpa/

nameser.h

40 lines

lib/

libc/

nameser/

Symbol.map

10 lines

Diff 119275

View Options

include/arpa/nameser.h