Page MenuHomeFreeBSD
Differential D38752

netmap: Fix compiler warnings in tools
ClosedPublic
Actions

Authored by markj on Feb 23 2023, 11:43 PM.
Tags
None
Referenced Files
F158703325: D38752.id118017.diff
Thu, Jun 4, 9:14 PM
F158689024: D38752.id118009.diff
Thu, Jun 4, 5:39 PM
F158649949: D38752.diff
Thu, Jun 4, 8:25 AM
Unknown Object (File)
Fri, May 15, 3:30 PM
Unknown Object (File)
Fri, May 15, 12:50 AM
Unknown Object (File)
Thu, May 14, 11:35 PM
Unknown Object (File)
Thu, May 14, 11:35 PM
Unknown Object (File)
Thu, May 14, 8:21 PM
View All Files
Subscribers
imp

Details

Reviewers
vmaffione
Commits
rG25e0844eda66: netmap: Fix compiler warnings in tools
rG538c66eabda5: netmap: Fix compiler warnings in tools
Summary
  • Remove write-only variables, or hide them in cases where their use is conditional or commented out.
  • Check for errors from cmd_apply() in nmreplay.
  • Use ANSI C definitions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49984
Build 46876: arc lint + arc unit

Event Timeline

markj created this revision.Feb 23 2023, 11:43 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2023, 11:43 PM
markj requested review of this revision.Feb 23 2023, 11:43 PM
Harbormaster completed remote builds in B49984: Diff 117848.Feb 23 2023, 11:44 PM
markj added inline comments.Feb 23 2023, 11:49 PM
tools/tools/netmap/lb.c
392

This one gives a compile error with clang 15.

vmaffione requested changes to this revision.Feb 26 2023, 3:41 PM
vmaffione added inline comments.
tools/tools/netmap/pkt-gen.c
1524

why not dropping this?

1552

why not dropping this? It looks like leftover code

This revision now requires changes to proceed.Feb 26 2023, 3:41 PM
markj added inline comments.Feb 27 2023, 2:15 PM
tools/tools/netmap/pkt-gen.c
1552

There are some commented-out prints that reference rx. Should I remove those as well?

markj updated this revision to Diff 118009.Feb 27 2023, 3:27 PM

Drop commented-out lines in pkt-gen.

Harbormaster completed remote builds in B50047: Diff 118009.Feb 27 2023, 3:27 PM
vmaffione accepted this revision.Feb 27 2023, 5:26 PM

Yeah, if not used since you are here please clean it up.

This revision is now accepted and ready to land.Feb 27 2023, 5:26 PM
Closed by commit rG538c66eabda5: netmap: Fix compiler warnings in tools (authored by markj). · Explain WhyFeb 27 2023, 6:44 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG538c66eabda5: netmap: Fix compiler warnings in tools.
markj added a commit: rG25e0844eda66: netmap: Fix compiler warnings in tools.Mar 13 2023, 3:54 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
netmap/
5 lines
2 lines
13 lines

Diff 117848

View Options

tools/tools/netmap/lb.c

Loading...
View Options

tools/tools/netmap/nmreplay.c

Loading...
View Options

tools/tools/netmap/pkt-gen.c

Loading...