fusefs: fix some resource leaks
ClosedPublic
Actions

Authored by asomers on Feb 12 2023, 12:27 AM.

Details

Reviewers

Commits

rGfbb102b2cec5: fusefs: fix some resource leaks
rG57756461548b: fusefs: fix some resource leaks
rG1bdf879b97b6: fusefs: fix some resource leaks

Summary

fusefs: fix some resource leaks

fusefs would leak tickets in three cases:

After FUSE_CREATE, if the server returned a bad inode number.
After a FUSE_FALLOCATE operation during VOP_DEALLOCATE
After a FUSE_FALLOCATE operation during VOP_ALLOCATE

MFC after: 2 weeks

Test Plan

Ran existing test cases while watching sysctl vfs.fusefs.stats

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Feb 12 2023, 12:27 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2023, 12:27 AM

asomers requested review of this revision.Feb 12 2023, 12:27 AM

Harbormaster completed remote builds in B49710: Diff 117017.Feb 12 2023, 12:27 AM

emaste accepted this revision.Feb 14 2023, 9:01 PM

This revision is now accepted and ready to land.Feb 14 2023, 9:01 PM

Closed by commit rG1bdf879b97b6: fusefs: fix some resource leaks (authored by asomers). · Explain WhyFeb 14 2023, 9:21 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG1bdf879b97b6: fusefs: fix some resource leaks.

asomers added a commit: rG57756461548b: fusefs: fix some resource leaks.Feb 19 2023, 4:49 PM

asomers added a commit: rGfbb102b2cec5: fusefs: fix some resource leaks.Feb 19 2023, 11:43 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_vnops.c

5 lines

Diff 117249

View Options

sys/fs/fuse/fuse_vnops.c

Show All 38 Lines

.Dt NVMECONTROL 8

.Os

.Sh NAME

.Nm nvmecontrol

.Nd NVM Express control utility

.Sh SYNOPSIS

.Nm

.Ic devlist

.Op Fl h

.Nm

.Ic identify

.Op Fl v

.Op Fl x

.Op Fl n Ar nsid

.Aq Ar device-id | Ar namespace-id

.Nm

.Ic perftest

▲ Show 20 Lines • Show All 149 Lines • ▼ Show 20 Lines

.Aq Ar device-id

.Nm

.Ic io-passthru

.Op args

.Aq Ar namespace-id

.Sh DESCRIPTION

NVM Express (NVMe) is a storage protocol standard, for SSDs and other

high-speed storage devices over PCI Express.

.Ss devlist

List all NVMe controllers and namespaces along with their device nodes.

With the

.Fl h

argument, use unit suffixes: Byte, Kibibyte, Mebibyte, Gibibyte, Tebibyte

and Pebibyte (based on powers of 1024) when showing the disk space.

By default, uses Mebibyte.

pauamma_gundo.comUnsubmitted

Not Done

and Pebibyte (based on powers of 1024) when showing the disk space.

- By default, shows in Mebityte.

+ By default, shows in Mebibyte.

.Ss identify

Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of taste. The typo itself is the important thing.

pauamma_gundo.com: Maybe also s/shows in/uses/ for consistency with the previous sentence, but that's a matter of…

.Ss identify

The identify commands reports information from the drive's

.Dv IDENTIFY_CONTROLLER

if a

.Ar device-id

is specified.

It reports

.Dv IDENTIFY_NAMESPACE

▲ Show 20 Lines • Show All 530 Lines • Show Last 20 Lines

fusefs: fix some resource leaksClosedPublicActions